From: Chao Yu Subject: Re: [PATCH v2 2/2] f2fs: fix setattr project check upon fssetxattr ioctl Date: Mon, 10 Sep 2018 22:45:38 +0800 Message-ID: References: <1536484514-16202-1-git-send-email-wshilong1991@gmail.com> <1536484514-16202-2-git-send-email-wshilong1991@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: adilger@dilger.ca, wshilong@ddn.com, dchinner@redhat.com To: Wang Shilong , linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Return-path: In-Reply-To: <1536484514-16202-2-git-send-email-wshilong1991@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net List-Id: linux-ext4.vger.kernel.org On 2018/9/9 17:15, Wang Shilong wrote: > From: Wang Shilong > > Currently, project quota could be changed by fssetxattr > ioctl, and existed permission check inode_owner_or_capable() > is obviously not enough, just think that common users could > change project id of file, that could make users to > break project quota easily. > > This patch try to follow same regular of xfs project > quota: > > "Project Quota ID state is only allowed to change from > within the init namespace. Enforce that restriction only > if we are trying to change the quota ID state. > Everything else is allowed in user namespaces." > > Besides that, check and set project id'state should > be an atomic operation, protect whole operation with > inode lock. > > Signed-off-by: Wang Shilong It looks good to me, thanks for the patch, Shilong. :) Reviewed-by: Chao Yu Thanks,