Return-Path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:34061 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727277AbeK0JiV (ORCPT ); Tue, 27 Nov 2018 04:38:21 -0500 Received: by mail-pg1-f196.google.com with SMTP id 17so6857585pgg.1 for ; Mon, 26 Nov 2018 14:42:41 -0800 (PST) Date: Mon, 26 Nov 2018 14:42:39 -0800 From: Omar Sandoval To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V12 15/20] block: allow bio_for_each_segment_all() to iterate over multi-page bvec Message-ID: <20181126224239.GL30411@vader> References: <20181126021720.19471-1-ming.lei@redhat.com> <20181126021720.19471-16-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181126021720.19471-16-ming.lei@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, Nov 26, 2018 at 10:17:15AM +0800, Ming Lei wrote: > This patch introduces one extra iterator variable to bio_for_each_segment_all(), > then we can allow bio_for_each_segment_all() to iterate over multi-page bvec. > > Given it is just one mechannical & simple change on all bio_for_each_segment_all() > users, this patch does tree-wide change in one single patch, so that we can > avoid to use a temporary helper for this conversion. > > Reviewed-by: Christoph Hellwig Reviewed-by: Omar Sandoval > Signed-off-by: Ming Lei > --- > block/bio.c | 27 ++++++++++++++++++--------- > block/bounce.c | 6 ++++-- > drivers/md/bcache/btree.c | 3 ++- > drivers/md/dm-crypt.c | 3 ++- > drivers/md/raid1.c | 3 ++- > drivers/staging/erofs/data.c | 3 ++- > drivers/staging/erofs/unzip_vle.c | 3 ++- > fs/block_dev.c | 6 ++++-- > fs/btrfs/compression.c | 3 ++- > fs/btrfs/disk-io.c | 3 ++- > fs/btrfs/extent_io.c | 9 ++++++--- > fs/btrfs/inode.c | 6 ++++-- > fs/btrfs/raid56.c | 3 ++- > fs/crypto/bio.c | 3 ++- > fs/direct-io.c | 4 +++- > fs/exofs/ore.c | 3 ++- > fs/exofs/ore_raid.c | 3 ++- > fs/ext4/page-io.c | 3 ++- > fs/ext4/readpage.c | 3 ++- > fs/f2fs/data.c | 9 ++++++--- > fs/gfs2/lops.c | 6 ++++-- > fs/gfs2/meta_io.c | 3 ++- > fs/iomap.c | 6 ++++-- > fs/mpage.c | 3 ++- > fs/xfs/xfs_aops.c | 5 +++-- > include/linux/bio.h | 11 +++++++++-- > include/linux/bvec.h | 30 ++++++++++++++++++++++++++++++ > 27 files changed, 125 insertions(+), 45 deletions(-)