Return-Path: Received: from imap.thunk.org ([74.207.234.97]:46280 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727315AbeKGIR2 (ORCPT ); Wed, 7 Nov 2018 03:17:28 -0500 Date: Tue, 6 Nov 2018 17:49:54 -0500 From: "Theodore Y. Ts'o" To: Vasily Averin Cc: linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/11] ext4: remove useless brelse call in ext4_xattr_inode_update_ref() Message-ID: <20181106224954.GI2570@thunk.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed, Oct 31, 2018 at 12:58:46AM +0300, Vasily Averin wrote: > brelse(iloc.bh) is useless here, it is always called with iloc.bh = NULL > > Fixes dec214d00e0d ("ext4: xattr inode deduplication") # 4.13 > cc: Tahsin Erdogan > > Signed-off-by: Vasily Averin Applied. I droppped the "Fixes" since it's really not needed for stable kernel; this is really more of a cleanup. I used the commit description: ext4: remove unneeded brelse call in ext4_xattr_inode_update_ref() - Ted