Return-Path: Received: from mail-lj1-f196.google.com ([209.85.208.196]:39565 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbeKCBWl (ORCPT ); Fri, 2 Nov 2018 21:22:41 -0400 Received: by mail-lj1-f196.google.com with SMTP id a28-v6so2230643ljd.6 for ; Fri, 02 Nov 2018 09:15:03 -0700 (PDT) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com. [209.85.208.175]) by smtp.gmail.com with ESMTPSA id l7sm227313lfb.7.2018.11.02.09.15.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Nov 2018 09:15:01 -0700 (PDT) Received: by mail-lj1-f175.google.com with SMTP id t22-v6so2225072lji.7 for ; Fri, 02 Nov 2018 09:15:01 -0700 (PDT) MIME-Version: 1.0 References: <20181022105944.GA1411@gmail.com> <29dba7c2-f612-7b35-d665-9939d7e10eb8@virtuozzo.com> In-Reply-To: <29dba7c2-f612-7b35-d665-9939d7e10eb8@virtuozzo.com> From: Linus Torvalds Date: Fri, 2 Nov 2018 09:09:32 -0700 Message-ID: Subject: Re: [GIT PULL] Compiler Attributes for v4.20-rc1 To: Andrey Ryabinin , Vasily Gorbik , Martin Schwidefsky Cc: Miguel Ojeda , dan.carpenter@oracle.com, adilger.kernel@dilger.ca, yamada.masahiro@socionext.com, michal.lkml@markovi.net, rostedt@goodmis.org, mchehab+samsung@kernel.org, olof@lxom.net, Konstantin Ryabitsev , David Miller , Kees Cook , tglx@linutronix.de, Ingo Molnar , paullawrence@google.com, sandipan@linux.vnet.ibm.com, andreyknvl@google.com, David Woodhouse , will.deacon@arm.com, Philippe Ombredanne , paul.burton@mips.com, rientjes@google.com, w@1wt.eu, msebor@gmail.com, Chris Li , Jonathan Corbet , "Theodore Ts'o" , Geert Uytterhoeven , Rasmus Villemoes , joe@perches.com, Arnd Bergmann , asmadeus@codewreck.org, stefan@agner.ch, luc.vanoostenryck@gmail.com, Nick Desaulniers , Andrew Morton , Greg KH , linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org, linux-sparse@vger.kernel.org, linux-kbuild@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, Nov 2, 2018 at 2:43 AM Andrey Ryabinin wrote: > > You're right, version checks shouldn't matter here. But __no_sanitize_address_or_inline > shouldn't have been added in the first place, because we already have almost the same >__no_kasan_or_inline: Ahh, very good. Vasily, Martin - since __no_sanitize_address_or_inline was added just for s390, would you mind replacing it with __no_kasan_or_inline instead, and testing that in whatever failed before? Then we can just remove that unnecessary symbol #define entirely.. Thanks, Linus