Return-Path: Received: from verein.lst.de ([213.95.11.211]:51531 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728520AbeKVAfB (ORCPT ); Wed, 21 Nov 2018 19:35:01 -0500 Date: Wed, 21 Nov 2018 15:00:27 +0100 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V11 10/19] block: loop: pass multi-page bvec to iov_iter Message-ID: <20181121140027.GA2323@lst.de> References: <20181121032327.8434-1-ming.lei@redhat.com> <20181121032327.8434-11-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181121032327.8434-11-ming.lei@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 1ad6eafc43f2..a281b6737b61 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -805,6 +805,10 @@ struct req_iterator { > __rq_for_each_bio(_iter.bio, _rq) \ > bio_for_each_segment(bvl, _iter.bio, _iter.iter) > > +#define rq_for_each_bvec(bvl, _rq, _iter) \ > + __rq_for_each_bio(_iter.bio, _rq) \ > + bio_for_each_bvec(bvl, _iter.bio, _iter.iter) > + I think this should go into the patch adding bio_for_each_bvec and friends. Otherwise looks fine: Reviewed-by: Christoph Hellwig