Return-Path: Received: from mout.gmx.net ([212.227.15.15]:32859 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbeKUV3l (ORCPT ); Wed, 21 Nov 2018 16:29:41 -0500 Subject: Re: [PATCH] ext2: compare old and new mode before setting update_mode flag To: Jan Kara Cc: jack@suse.com, linux-ext4@vger.kernel.org References: <20181117090100.29063-1-cgxu519@gmx.com> <20181119100425.GD16427@quack2.suse.cz> From: cgxu519 Message-ID: Date: Wed, 21 Nov 2018 18:55:28 +0800 MIME-Version: 1.0 In-Reply-To: <20181119100425.GD16427@quack2.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-ext4-owner@vger.kernel.org List-ID: On 11/19/18 6:04 PM, Jan Kara wrote: > On Sat 17-11-18 17:01:00, Chengguang Xu wrote: >> If new mode is the same as old mode we don't have to reset >> inode mode in the rest of the code, so compare old and new >> mode before setting update_mode flag. >> >> Signed-off-by: Chengguang Xu > I don't think this is quite correct. E.g. I would think that i_ctime should > be updated even if the effective mode resulting from acl did not change. I think  __ext2_set_acl() will probably update i_ctime in this case, am I missing something? Thanks, > --- > fs/ext2/acl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/ext2/acl.c b/fs/ext2/acl.c > index cf4c77f8dd08..f4dd728393c8 100644 > --- a/fs/ext2/acl.c > +++ b/fs/ext2/acl.c > @@ -226,7 +226,8 @@ ext2_set_acl(struct inode *inode, struct posix_acl *acl, int type) > error = posix_acl_update_mode(inode, &mode, &acl); > if (error) > return error; > - update_mode = 1; > + if (mode != inode->i_mode) > + update_mode = 1; > } > error = __ext2_set_acl(inode, acl, type); > if (!error && update_mode) { > -- > 2.17.2 > >