Return-Path: Received: from bhuna.collabora.co.uk ([46.235.227.227]:39702 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726194AbeLIUxd (ORCPT ); Sun, 9 Dec 2018 15:53:33 -0500 From: Gabriel Krisman Bertazi To: Linus Torvalds Cc: "Theodore Ts'o" , linux-fsdevel , kernel@collabora.com, linux-ext4@vger.kernel.org, sfrench@samba.org Subject: Re: [PATCH v4 00/23] Ext4 Encoding and Case-insensitive support References: <20181206230903.30011-1-krisman@collabora.com> <20181208194128.GE20708@thunk.org> <20181209050326.GA28659@mit.edu> Date: Sun, 09 Dec 2018 15:53:28 -0500 In-Reply-To: (Linus Torvalds's message of "Sun, 9 Dec 2018 09:41:13 -0800") Message-ID: <871s6qo20n.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-ext4-owner@vger.kernel.org List-ID: Linus Torvalds writes: > On Sat, Dec 8, 2018 at 9:03 PM Theodore Y. Ts'o wrote: > Either you have a horrible fundamental design mistake that has > different per-filesystem locales, or you don't. > > If you don't, you shouldn't be touching any of the nls code. > > Whatever unicode tables you use for case folding shouldn't be in the nls code. Hi Linus, As Ted mentioned the SMB case, in my understanding, we might have more users for in-kernel ut8 normalization/casefold comparison functions than just ext4 in the future. Steve French (in cc.), for instance, mentioned his interest in using this higher level NLS API when I first submitted these patches. My first RFC actually included this code as a separated module inside lib/ instead of touching NLS, but I found myself rewriting much of the same APIs that already existed in NLS. That is why I merged my work with that subsystem. I am open to rethinking it, if there is a better alternative. Thanks, -- Gabriel Krisman Bertazi