Return-Path: Received: from mail-eopbgr680112.outbound.protection.outlook.com ([40.107.68.112]:10223 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726011AbeL2ESp (ORCPT ); Fri, 28 Dec 2018 23:18:45 -0500 Date: Fri, 28 Dec 2018 22:14:16 -0500 From: "Theodore Y. Ts'o" To: Peter Maydell , Andreas Dilger , Florian Weimer , linux-fsdevel , Linux API , Ext4 Developers List , , , Arnd Bergmann , , , lkml - Kernel Mailing List , QEMU Developers , , Subject: Re: [Qemu-devel] d_off field in struct dirent and 32-on-64 emulation Message-ID: <20181229031416.GH5864@mit.edu> References: <87bm56vqg4.fsf@mid.deneb.enyo.de> <9C6A7D45-CF53-4C61-B5DD-12CA0D419972@dilger.ca> <20181229021157.GG5864@mit.edu> <20181229023721.GA9291@nautica> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20181229023721.GA9291@nautica> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sat, Dec 29, 2018 at 03:37:21AM +0100, Dominique Martinet wrote: > > Are there going to be cases where a process or a thread will sometimes > > want the 64-bit interface, and sometimes want the 32-bit interface? > > Or is it always going to be one or the other? I wonder if we could > > simply add a new flag to the process personality(2) flags. > > That would likely work for qemu user, but the qemu system+9p case is > going to be more painful.. > More precisely, the 9p protocol does not plan for anything other than > 64bit offset so if the vfs needs to hand out a 32bit offset we'll need > to make a correspondance table between the 32bit offsets we hand off and > the 64bit ones to use; unless some flag can be passed at lopen to tell > the server to always hand out 32bit offsets for this directory... And if > we do that then 9p servers will need a way to use both APIs in parallel > for both types of directories. How about if we add a fcntl(2) mediated flag, which is tied to a struct file? Would that be more or less painful for 9p and qemu system+9p? - Ted