Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v2 1/2] e2fsck: allow to check >2GB sized directory
From:   Artem Blagodarenko <artem.blagodarenko@gmail.com>
In-Reply-To: <20181214075054.47359-1-artem.blagodarenko@gmail.com>
Date:   Wed, 30 Jan 2019 12:01:21 +0300
Cc:     adilger.kernel@dilger.ca
Content-Transfer-Encoding: quoted-printable
Message-Id: <4F93EC84-847D-41C2-8155-97BCED9BA4A0@gmail.com>
References: <20181214075054.47359-1-artem.blagodarenko@gmail.com>
To:     linux-ext4 <linux-ext4@vger.kernel.org>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

Hello, Theodore.

 Do I need fix something in this patch series?

Thank you.

> On 14 Dec 2018, at 10:50, Artem Blagodarenko =
<artem.blagodarenko@gmail.com> wrote:
>=20
> After large_dir feature has been added, e2fsprogs is
> ready for directories > 2GB, so we can remove e2fsck
> directory size check.
>=20
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>
> ---
> e2fsck/pass1.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c
> index 5c0b92d5..5c413610 100644
> --- a/e2fsck/pass1.c
> +++ b/e2fsck/pass1.c
> @@ -3647,9 +3647,12 @@ static int process_block(ext2_filsys fs,
> 		}
> 	}
>=20
> -	if (p->is_dir && blockcnt > (1 << (21 - =
fs->super->s_log_block_size)))
> +	if (p->is_dir && !ext2fs_has_feature_largedir(fs->super) &&
> +	    blockcnt > (1 << (21 - fs->super->s_log_block_size)))
> 		problem =3D PR_1_TOOBIG_DIR;
> -	if (p->is_reg && p->num_blocks+1 >=3D p->max_blocks)
> +	if (p->is_dir && p->num_blocks + 1 >=3D p->max_blocks)
> +		problem =3D PR_1_TOOBIG_DIR;
> +	if (p->is_reg && p->num_blocks + 1 >=3D p->max_blocks)
> 		problem =3D PR_1_TOOBIG_REG;
> 	if (!p->is_dir && !p->is_reg && blockcnt > 0)
> 		problem =3D PR_1_TOOBIG_SYMLINK;
> --=20
> 2.14.3
>=20