From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <CA49E193-ADAA-4D69-8378-D35BEF0B72C5@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_BD737D8F-F6F1-459D-9C54-7743A378B729";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v2 1/2] e2fsck: allow to check >2GB sized directory
Date:   Wed, 30 Jan 2019 10:58:59 -0700
In-Reply-To: <20181214075054.47359-1-artem.blagodarenko@gmail.com>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>
To:     Artem Blagodarenko <artem.blagodarenko@gmail.com>
References: <20181214075054.47359-1-artem.blagodarenko@gmail.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_BD737D8F-F6F1-459D-9C54-7743A378B729
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Dec 14, 2018, at 12:50 AM, Artem Blagodarenko =
<artem.blagodarenko@gmail.com> wrote:
>=20
> After large_dir feature has been added, e2fsprogs is
> ready for directories > 2GB, so we can remove e2fsck
> directory size check.
>=20
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> e2fsck/pass1.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c
> index 5c0b92d5..5c413610 100644
> --- a/e2fsck/pass1.c
> +++ b/e2fsck/pass1.c
> @@ -3647,9 +3647,12 @@ static int process_block(ext2_filsys fs,
> 		}
> 	}
>=20
> -	if (p->is_dir && blockcnt > (1 << (21 - =
fs->super->s_log_block_size)))
> +	if (p->is_dir && !ext2fs_has_feature_largedir(fs->super) &&
> +	    blockcnt > (1 << (21 - fs->super->s_log_block_size)))
> 		problem =3D PR_1_TOOBIG_DIR;
> -	if (p->is_reg && p->num_blocks+1 >=3D p->max_blocks)
> +	if (p->is_dir && p->num_blocks + 1 >=3D p->max_blocks)
> +		problem =3D PR_1_TOOBIG_DIR;
> +	if (p->is_reg && p->num_blocks + 1 >=3D p->max_blocks)
> 		problem =3D PR_1_TOOBIG_REG;
> 	if (!p->is_dir && !p->is_reg && blockcnt > 0)
> 		problem =3D PR_1_TOOBIG_SYMLINK;
> --
> 2.14.3
>=20


Cheers, Andreas


--Apple-Mail=_BD737D8F-F6F1-459D-9C54-7743A378B729
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAlxR5eMACgkQcqXauRfM
H+D2ew/+Mg8zFSCRqlcGqGj8jrVSY09uRshRDBBAOD8ivGwQ2gqmHqna3PxQsm7/
xNq0mrBY2OXRKrSmERvNS+X7cLcTjYw1mXtArbr3oTyLe703RqthtV6X7O7mCvf+
QGVssUpCLaNcFcLsvC/3SEq2onyQhGgke9d/Zq9I+biyiz9WUsjc94ApwWEkhnpQ
4s+tXAHLdWgU/HvjiDvbVbuqBJyk5Et8mXHTqRraqKezIif44ThpYzU51elRcRx8
hWny/i3wVJyJlAFuvecCcAAECjyfI2kziY9vS9zd/lbGsUAFy4hXhUasyuEd8762
vEwy9a+U7CcTQRADLvlvozi7ZVCvAzSsFvpLhsTqfPWdrB6SBhbebJr9BOwn7wvH
TEYWkMzhZUiEIhHt1AAx6//UfBCTEg8dM8MVOlRIpD0RiqXfwXE4PXGRhqvf2eg7
DRx0OrnoNR7OaXbbrEcVbLOyhkuklppatjSBW1s2tmlb6/Vwmj6o9vMcMLY5uyiG
X8+40S8EzvZtVhAGlpAl2gHKWMJfA4fmp/EKNfreWVcXB7Mp4VcJDBTPGUJbXVd1
BQPwe4aU+NysyaeL/ZrK+rK3IOj1JY4h/uMv6rXtbRC7vyCstlkODeylQG020tvc
NyyTF+iVWjxxNIpaSoeV2hI7yVAn6r6gCoFHqXa1WjgYhafC6C0=
=CIzH
-----END PGP SIGNATURE-----

--Apple-Mail=_BD737D8F-F6F1-459D-9C54-7743A378B729--