Received-SPF: Pass (protection.outlook.com: domain of mit.edu designates
 18.9.28.11 as permitted sender) receiver=protection.outlook.com;
 client-ip=18.9.28.11; helo=outgoing.mit.edu;
Date:   Sun, 10 Feb 2019 23:54:29 -0500
From:   "Theodore Y. Ts'o" <tytso@mit.edu>
To:     Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
CC:     <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: unlock unused_pages timely when doing writeback
Message-ID: <20190211045429.GI23000@mit.edu>
References: <20190129020531.1665-1-xiaoguang.wang@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20190129020531.1665-1-xiaoguang.wang@linux.alibaba.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2019 04:54:31.8595
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 69ea3d2c-0d8f-438e-dbb4-08d68fdd0316
X-MS-Exchange-CrossTenant-Id: 64afd9ba-0ecf-4acf-bc36-935f6235ba8b
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=64afd9ba-0ecf-4acf-bc36-935f6235ba8b;Ip=[18.9.28.11];Helo=[outgoing.mit.edu]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB4496
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On Tue, Jan 29, 2019 at 10:05:31AM +0800, Xiaoguang Wang wrote:
> In mpage_add_bh_to_extent(), when accumulated extents length is greater
> than MAX_WRITEPAGES_EXTENT_LEN or buffer head's b_stat is not equal, we
> will not continue to search unmapped area for this page, but note this
> page is locked, and will only be unlocked in mpage_release_unused_pages()
> after ext4_io_submit, if io also is throttled by blk-throttle or similar
> io qos, we will hold this page locked for a while, it's unnecessary.
> 
> I think the best fix is to refactor mpage_add_bh_to_extent() to let it
> return some hints whether to unlock this page, but given that we will
> improve dioread_nolock later, we can let it done later, so currently
> the simple fix would just call mpage_release_unused_pages() before
> ext4_io_submit().
> 
> Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>

Thanks, applied.

					- Ted