Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7879C4360F for ; Wed, 3 Apr 2019 09:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEACA21473 for ; Wed, 3 Apr 2019 09:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726074AbfDCJgN (ORCPT ); Wed, 3 Apr 2019 05:36:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:34246 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725935AbfDCJgN (ORCPT ); Wed, 3 Apr 2019 05:36:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 266ACABF0; Wed, 3 Apr 2019 09:36:12 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 351CA1E3FFD; Wed, 3 Apr 2019 11:36:10 +0200 (CEST) Date: Wed, 3 Apr 2019 11:36:10 +0200 From: Jan Kara To: Dave Chinner Cc: Jan Kara , Kanchan Joshi , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, axboe@fb.com, prakash.v@samsung.com, anshul@samsung.com, joshiiitr@gmail.com Subject: Re: [PATCH v3 3/7] block: add write-hint to stream-id conversion Message-ID: <20190403093610.GE8836@quack2.suse.cz> References: <1553846032-4451-1-git-send-email-joshi.k@samsung.com> <1553846032-4451-4-git-send-email-joshi.k@samsung.com> <20190401050821.GQ23020@dastard> <20190402092044.GE12133@quack2.suse.cz> <20190402203508.GT26298@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190402203508.GT26298@dastard> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed 03-04-19 07:35:08, Dave Chinner wrote: > On Tue, Apr 02, 2019 at 11:20:44AM +0200, Jan Kara wrote: > > On Mon 01-04-19 16:08:21, Dave Chinner wrote: > > > On Fri, Mar 29, 2019 at 01:23:48PM +0530, Kanchan Joshi wrote: > > > > + if(streamid > nr_streams) > > > > + streamid = 0; > > > > > > So, basically, we'll compress all the kernel hints down to "no hint" > > > if there are more user streams than the device supports? > > > > > > Surely we should be reserving a stream for the kernel hints separate > > > from the user and "none" streams when we have limited device streams > > > available... > > > > The question is what to do in a situation when the device has exactly as > > many hints as we currently offer to userspace. > > Then do what we do now for that case. For every other case, the > kernel should have reserved space and not get intermingled with > userspace hints. Yup, we are on the same page then. Honza -- Jan Kara SUSE Labs, CR