Date:   Sat, 6 Apr 2019 15:53:42 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Gabriel Krisman Bertazi <krisman@collabora.com>
Cc:     linux-ext4@vger.kernel.org, sfrench@samba.org,
        darrick.wong@oracle.com, jlayton@kernel.org, bfields@fieldses.org,
        paulus@samba.org, linux-fsdevel@vger.kernel.org,
        Olaf Weber <olaf@sgi.com>,
        Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Subject: Re: [PATCH RFC v6 04/11] unicode: reduce the size of utf8data[]
Message-ID: <20190406195342.GA18897@mit.edu>
References: <20190318202745.5200-1-krisman@collabora.com>
 <20190318202745.5200-5-krisman@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190318202745.5200-5-krisman@collabora.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 18, 2019 at 04:27:38PM -0400, Gabriel Krisman Bertazi wrote:
> From: Olaf Weber <olaf@sgi.com>
> 
> Remove the Hangul decompositions from the utf8data trie, and do
> algorithmic decomposition to calculate them on the fly. To store
> the decomposition the caller of utf8lookup()/utf8nlookup() must
> provide a 12-byte buffer, which is used to synthesize a leaf with
> the decomposition. Trie size is reduced from 245kB to 90kB.

I'm seeing sizes much smaller; the actual utf8data[] array is 63,584.
And size utf8-norm.o reports:

   text	   data	    bss	    dec	    hex	filename
  68752	     96	      0	  68848	  10cf0	fs/unicode/utf8-norm.o

Were you measuring the size of the utf8-norm.o file?  That will vary
in size depending on whether debugging symbols are enabled, etc.

   		     	     	       	       - Ted