Date:   Sat, 6 Apr 2019 19:03:52 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Jiufei Xue <jiufei.xue@linux.alibaba.com>
Cc:     linux-ext4@vger.kernel.org, jack@suse.cz, renzhen@linux.alibaba.com
Subject: Re: [PATCH v2] jbd2: check superblock mapped prior to committing
Message-ID: <20190406230352.GG18897@mit.edu>
References: <20190328100750.71045-1-jiufei.xue@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190328100750.71045-1-jiufei.xue@linux.alibaba.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 28, 2019 at 06:07:50PM +0800, Jiufei Xue wrote:
> We hit a BUG at fs/buffer.c:3057 if we detached the nbd device
> before unmounting ext4 filesystem.
> 
> The typical chain of events leading to the BUG:
> jbd2_write_superblock
>   submit_bh
>     submit_bh_wbc
>       BUG_ON(!buffer_mapped(bh));
> 
> The block device is removed and all the pages are invalidated. JBD2
> was trying to write journal superblock to the block device which is
> no longer present.
> 
> Fix this by checking the journal superblock's buffer head prior to
> submitting.

Thanks, applied.

					- Ted