From:   Gabriel Krisman Bertazi <krisman@collabora.com>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-ext4@vger.kernel.org,
        Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Subject: Re: [PATCH] debugfs: fix encoding handling in dx_hash command
Organization: Collabora
References: <20190422210124.181075-1-ebiggers@kernel.org>
Date:   Tue, 23 Apr 2019 00:07:12 -0400
In-Reply-To: <20190422210124.181075-1-ebiggers@kernel.org> (Eric Biggers's
        message of "Mon, 22 Apr 2019 14:01:23 -0700")
Message-ID: <85o94xs6tr.fsf@collabora.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

Eric Biggers <ebiggers@kernel.org> writes:

> From: Eric Biggers <ebiggers@google.com>
>
> Fix the following bugs:
>
> 1. 'encoding' and 'hash_flags' are not initialized, causing a segfault.
>
> 2. 'hash_flags' incorrectly uses a __bitwise type.
>
> 3. The optstring doesn't contain "c" or "e", so the -c and -e options
>    aren't recognized.
>
> 4. The code that handles the -e option always returns.
>

Ugly. Thanks for finding it.

Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>


-- 
Gabriel Krisman Bertazi