From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <EB85EE47-BCCC-4A0C-9A33-0A5AC7239554@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_D176D8A4-852F-4A5B-BEA3-8D4911BAAF0A";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v2] ext4: cond_resched in work-heavy group loops
Date:   Wed, 24 Apr 2019 08:21:36 +0200
In-Reply-To: <20190423211329.149642-1-khazhy@google.com>
Cc:     Theodore Ts'o <tytso@mit.edu>,
        linux-ext4 <linux-ext4@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Jan Kara <jack@suse.cz>
To:     Khazhismel Kumykov <khazhy@google.com>
References: <CACGdZYLCi+Or=afmBK8hbP3Ay8x8Oaqnp0Yr+jf1PoQiMc7_DQ@mail.gmail.com>
 <20190423211329.149642-1-khazhy@google.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_D176D8A4-852F-4A5B-BEA3-8D4911BAAF0A
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Apr 23, 2019, at 11:13 PM, Khazhismel Kumykov <khazhy@google.com> =
wrote:
>=20
> These functions may take a long time looping over many groups, which
> may cause issues for non-preempt kernels.
> ext4_mb_init_backend()
> ext4_setup_system_zone()
> ext4_mb_release()
>=20
> Signed-off-by: Khazhismel Kumykov <khazhy@google.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> v2:
> - a few other places that in testing showed to be slow
>=20
> fs/ext4/block_validity.c | 1 +
> fs/ext4/mballoc.c        | 2 ++
> 2 files changed, 3 insertions(+)
>=20
> diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c
> index 913061c0de1b..16134469ea3c 100644
> --- a/fs/ext4/block_validity.c
> +++ b/fs/ext4/block_validity.c
> @@ -155,6 +155,7 @@ int ext4_setup_system_zone(struct super_block *sb)
> 		return 0;
>=20
> 	for (i=3D0; i < ngroups; i++) {
> +		cond_resched();
> 		if (ext4_bg_has_super(sb, i) &&
> 		    ((i < 5) || ((i % flex_size) =3D=3D 0)))
> 			add_system_zone(sbi, =
ext4_group_first_block_no(sb, i),
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 8ef5f12bbee2..99ba720dbb7a 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2490,6 +2490,7 @@ static int ext4_mb_init_backend(struct =
super_block *sb)
> 	sbi->s_buddy_cache->i_ino =3D EXT4_BAD_INO;
> 	EXT4_I(sbi->s_buddy_cache)->i_disksize =3D 0;
> 	for (i =3D 0; i < ngroups; i++) {
> +		cond_resched();
> 		desc =3D ext4_get_group_desc(sb, i, NULL);
> 		if (desc =3D=3D NULL) {
> 			ext4_msg(sb, KERN_ERR, "can't read descriptor =
%u", i);
> @@ -2705,6 +2706,7 @@ int ext4_mb_release(struct super_block *sb)
>=20
> 	if (sbi->s_group_info) {
> 		for (i =3D 0; i < ngroups; i++) {
> +			cond_resched();
> 			grinfo =3D ext4_get_group_info(sb, i);
> #ifdef DOUBLE_CHECK
> 			kfree(grinfo->bb_bitmap);
> --
> 2.21.0.593.g511ec345e18-goog
>=20


Cheers, Andreas


--Apple-Mail=_D176D8A4-852F-4A5B-BEA3-8D4911BAAF0A
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAlzAAHAACgkQcqXauRfM
H+AJjQ//egWnCTo2jiw4DtSAWlxwng0FavawWfmuKUmPGmxIBHmw/JM/m86f0JuB
t5SpFCEdHBB7uX3KoxPF6ZF/dbrnToHmv7FGMkb/wBoefxHtbwyBD4UWeZL7ZZ0x
mc17+lEBXsUUOMXJuxr4r+8sZkn9FA+KB51Gmd0NN9R7hinY9Eia1BkDza5MYFf4
Hf/ibSpCCPV5pvSdB0mumTSOYW0bcLXX0Jdz33/Qked7+rgaI8kRgdywFa1cQeGl
+BemfwrGuoT9sOM/pxRxIdnUWARo06Of3RShA9PVA7kurVIwe8yV5gy2dUh1WUuL
FAA2VROXnG7Q1FbAKRSLZbpKyqiGBuJn6wCa9b1/z7zGUYw+T5kIlkOEULpLEM6q
4eufuucMkBWGewNa1PsI+ZKEqfJKhGoBOQj2/114hWdv4ONBbx/VXlNdc2DqIG/Z
fHb+/EvhRIwxYQwYKLB14SdcRTXchBU6F2LTQ2VOB14jBdZQYksSE+KmfZY5Mf/c
Wlzy1OvgT3CrKL4Hk99qtSM1iLF787nQue24+Ig0xyGGLZGJKPBqoebZ4/iDUm1g
mXeHRWkSOiUk5gKZzGvVHHi5UM1RK8tTL39xwOEcjSKdtEJ32hRJSh7FwgfE7E7r
CEFGOKE57oZu0gFJnzddf2DFHds1O9hMky3n7OV1CCFYVgoCrsk=
=+WoV
-----END PGP SIGNATURE-----

--Apple-Mail=_D176D8A4-852F-4A5B-BEA3-8D4911BAAF0A--