Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2060906yba; Thu, 25 Apr 2019 10:00:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqz/6Gqqx4gYH4UuV3UT9AJD6Vl6WIHRMEhdej85UaMwyTJolSvTU2wSvqH/ajs09tdgLTIj X-Received: by 2002:a17:902:8ec8:: with SMTP id x8mr8944906plo.21.1556211618239; Thu, 25 Apr 2019 10:00:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556211618; cv=none; d=google.com; s=arc-20160816; b=o0WFlTLQEj/t5Qa8hyC8BtAoVDMZ7+pUDLpok8z2T3nwTzVDUvREuisfKUW4lOqO8U uZGZsPNBn5+bMik7QnWVtZ9Ui7RyMd+uNbC7l3i2J8GRl8FhIN7iaCmFqw0gL0VuHT0M AkjuE5dafWRFdaveoaNdSPhxqscbAYhFEhBoS3MYWsqryOgt0dOS4Bk/58d+0t9e9An3 MMl/IGy6JjiWudaDdDvOgwh2VHEd0cSllGBDp2Iv27S3GLUiBPuHsFhnG12m4BkLFqLF 8lA/zDmqu46Z9vAswtiwSJl1Pzow/bDRrCpx3FPjllV3nQm4buEjTHuMjtiP1CirF6Qy Zy/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date; bh=xpwvf9a0s84doXzRvqUwBYS90ikF8ChHau2zlaSgyTk=; b=fiChLJ736O5SELCz8zsyUCTLJFYYveGY7t8iO2C3ZBB6Ta/m2m8g9uHFgjdcIruMv6 ngHY30uBHU28I5Vbz8CDfpQ0LN56JliSMpf0Cszz1dBFoa25tIhVdhdghbYTcZ0RzFl3 5RKO7xmkTxib7sgUBQorZCRKOx3kv0eGCyPmeBaRoZnnQxyY38QqQInr2PFK+jjoR7ax w7nCRxSxew6yTwZWOAIxscal6IsSwRVcdERUzt11R7TSLjD3zFGM1t9/pxnNUsPYR7pj C1Q7jg0EwKuVd84jwfnrTmJaYvWD05eOIFNHIKgmnUgURUijjRlVRz6MUqOK5EINL6pB 5NZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l185si10197672pgl.48.2019.04.25.09.59.54; Thu, 25 Apr 2019 10:00:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbfDYQ64 (ORCPT + 99 others); Thu, 25 Apr 2019 12:58:56 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:35208 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726026AbfDYQ6z (ORCPT ); Thu, 25 Apr 2019 12:58:55 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-109.corp.google.com [104.133.0.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x3PGwler031720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Apr 2019 12:58:48 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id E1F42420EEC; Thu, 25 Apr 2019 12:58:46 -0400 (EDT) Date: Thu, 25 Apr 2019 12:58:46 -0400 From: "Theodore Ts'o" To: Khazhismel Kumykov Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, jack@suse.cz Subject: Re: [PATCH v2] ext4: cond_resched in work-heavy group loops Message-ID: <20190425165846.GC4739@mit.edu> Mail-Followup-To: Theodore Ts'o , Khazhismel Kumykov , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, jack@suse.cz References: <20190423211329.149642-1-khazhy@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190423211329.149642-1-khazhy@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 23, 2019 at 02:13:29PM -0700, Khazhismel Kumykov wrote: > These functions may take a long time looping over many groups, which > may cause issues for non-preempt kernels. > ext4_mb_init_backend() > ext4_setup_system_zone() > ext4_mb_release() > > Signed-off-by: Khazhismel Kumykov Thanks, applied. - Ted