Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2917906yba; Sun, 28 Apr 2019 12:12:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqwxKaNhB+q1Y4s8dtx2ZJLo16S3Y7DWl+h06LWxtFWTIXxuKVQ8dHRyX7d1oWVxzY4CwegR X-Received: by 2002:a17:902:32b:: with SMTP id 40mr57548760pld.204.1556478779822; Sun, 28 Apr 2019 12:12:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556478779; cv=none; d=google.com; s=arc-20160816; b=SZgd2yvWx+JW1hGcaPpA3e8MmbH1wHm+9q4i5N6AgOpXYgVlKV3wt/AbE70I7ojSwC m2ubJFGMMzl5YrcPnLye2DHtVnKjLTE1JIHVjxJKHaSVpVrMdxacFRwbkjdrWvwU+JkU toaj8YJrRPAlmAVWHw4VyKgxoBrqLiAYFoS5MUJeiBadfnlDKe5saSsFDlWVoGhahhb5 gGA2qOYCU1J9JbHqtBAICDnMUuQgTcITt1Prr0txYhc8VKbznCvdW9CnaBcmA2Ig6lLW VtP4RkrlMJh+zNk9C7e4R/8ekywuR65u8rdZMnm4xbmyFd7iLzBFACM8Azstz+CgTeMY Hpwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=i3c+4fexLuz2vq8l3CZTlrIO3Cvf8IbIGj/XRrn4uWU=; b=wuo/+mhxgbNfPoc64vnLBt+cXlhWQcAJEgupe+YsgHLZrkDHmKujFPinxgXfp96k4i 1gyxOtrt3r94MUFSpE/BC2JiXbjjmb9X7+OroSPA/98Q70wnEA4oEYGTOj+wAD9+hAVo 4szwcfGgYcOI1igWbJlpjkSotdHwzA7d/4M3afgLjs6Q67+5IVe8iCzEDZJoslVnyuMI U67DklJopMhx7yeXk0kBvtdnQ3XO9e6ZB1A/lOQ/rVHXFueqBpjHDNB4HMC/vlJW88uf 1Sgsn88nIzqf43Psvw1wjjj6gm7CsDzLyb0Y0ixk3sWyVGNDVPQvHbSn4Seb6Dmxsr/N HE3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w2si2824748plk.274.2019.04.28.12.12.45; Sun, 28 Apr 2019 12:12:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727208AbfD1TLU (ORCPT + 99 others); Sun, 28 Apr 2019 15:11:20 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47352 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726447AbfD1TLU (ORCPT ); Sun, 28 Apr 2019 15:11:20 -0400 Received: from callcc.thunk.org (75-104-85-194.mobility.exede.net [75.104.85.194] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x3SJB9oR003477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 28 Apr 2019 15:11:15 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 8B81B420023; Sun, 28 Apr 2019 15:11:08 -0400 (EDT) Date: Sun, 28 Apr 2019 15:11:08 -0400 From: "Theodore Ts'o" To: Gabriel Krisman Bertazi Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH e2fsprogs 04/10] ext2fs: nls: Fix potential null dereference in utf8nlookup Message-ID: <20190428191108.GI24089@mit.edu> References: <20190413054317.7388-1-krisman@collabora.com> <20190413054317.7388-5-krisman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190413054317.7388-5-krisman@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Apr 13, 2019 at 01:43:11AM -0400, Gabriel Krisman Bertazi wrote: > Delay the access of data->offset until after the null check. This was > reported by 0-day on the kernel version of the script. > > Signed-off-by: Gabriel Krisman Bertazi Applied, thanks. - Ted