Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] e2fsck: Do not to be quiet if verbose option used.
From:   Alexey Lyashkov <alexey.lyashkov@gmail.com>
In-Reply-To: <20190428233847.GA31999@mit.edu>
Date:   Mon, 29 Apr 2019 07:16:36 +0300
Cc:     Artem Blagodarenko <artem.blagodarenko@gmail.com>,
        linux-ext4 <linux-ext4@vger.kernel.org>,
        Alexey Lyashkov <c17817@cray.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5DF9A5AD-ADCA-452B-8242-FE43946002ED@gmail.com>
References: <20190426130913.9288-1-c17828@cray.com>
 <20190428233847.GA31999@mit.edu>
To:     Theodore Ts'o <tytso@mit.edu>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

Theodore,

Usecase is simple. User use a -p with -v flag,
in this case, -p block any messages on console in case it successfully =
fixed.
It=E2=80=99s OK _without_ -v flag, situation is different with -v flag.
In this case, user expect to see mode debug info about check/fix =
process,
and =C2=ABno messages=C2=BB in this mode confuse a user, as he think =
=C2=ABno messages=C2=BB =3D=3D =C2=ABno bugs fixed=C2=BB,
but it=E2=80=99s not a true in common way.
=46rom other side, -p print a messages about fix process, but not for =
bitmaps, it=E2=80=99s source of additional
 confuse for the user, as he lack an info about FS changes during e2fsck =
run.


> 29 =D0=B0=D0=BF=D1=80. 2019 =D0=B3., =D0=B2 2:38, Theodore Ts'o =
<tytso@mit.edu> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):
>=20
> On Fri, Apr 26, 2019 at 04:09:13PM +0300, Artem Blagodarenko wrote:
>> From: Alexey Lyashkov <c17817@cray.com>
>>=20
>> e2fsck don't print a message if 'p' option used and error can be =
fixed without
>> user assistance,  but 'v' option asks to be more verbose, so user =
expect to
>> see any output. But not.
>> Fix this, by avoid message suppress with verbose option used.
>>=20
>> Change-Id: I358e9b04e44dd33fdb124c5663b2df0bf54ce370
>> Signed-off-by: Alexey Lyashkov <c17817@cray.com>
>> Cray-bug-id: LUS-6890
>=20
> I need to understand the use case of what you are trying to do here.
> The preen and verbose options were never intended to be mixed and this
> patch changes what the verbose flag does at a fairly fundamental
> level.  I'm not sure the results will be correct and they will almost
> certainly be surprising.
>=20
> So (a) what is the user trying to do, and (b) what does the user want
> to be trying to do?  Preen was intended to be used as part of the boot
> process, when multiple e2fsck's would be running in parallel, and so
> you don't *want* much in the way of verbosity.
>=20
>    	  	      	     	    - Ted