Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4291314yba; Mon, 29 Apr 2019 17:30:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqzooUFhQwvvMhbe11x9jutuBx/d1v/H8kPtM8YsuJh5OnXG4zxi/nd9AcpEtDhpQiDtyx1C X-Received: by 2002:a62:fb0a:: with SMTP id x10mr33169573pfm.179.1556584249260; Mon, 29 Apr 2019 17:30:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556584249; cv=none; d=google.com; s=arc-20160816; b=wCB5zc6Ny8CLfnxGJVSp8DSVXubqIZRgQAAyoQajzQrj6cmD9vgVqIzSUe4T2sqKAN ju1+YH+snvQ6gmrfZSfvPGx3y39obGH1ErVIw2do7GOmlf/kvOkQ0+raDnPYnZAVBaFG g4r9Wpp83xTMaK4KNtamzMAfuk/8CksxfkWTmU265Qlq2DyKXiDW3cJKoKwmIfwGAz7b bwGBdTROu/FXFXRk1breHFabr/HEpuEpu+ecEf9tgQfKyb3Whh4+NDNmWliWwBSehZ3c TH+zOUwnAKSzd5MjyvVJihUNdgvb9lhMflzV8dmaBIATX7H7P2KXpZQ4KQDhlLmrYEPl Y2ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rnbpRN3dar3hMqFtw7MpyRrExSiExRk5urYTkAAt6BU=; b=OXzmNO5ykntcBAPUYzYplkdoeipmjQ4kUJmj0b4zOqFYMoGDrCOD9CFCeJdFtPQDBT sY6WemvVZxbEJUt8y9t5QCqavlG3MgdK+8qakHEq9+RL71ZdHZ5+m5CVcrZR6kzNt1vm Tn105thADfBSDjKxBTic1kDyUl6MWErD8wtNqvmh2zxm9542ou7nAkulnh3+0ZoLWPsv H1ZqMYg8ZfGu0/AFZMR5rMc9og296a9SUnUByynFOm5zGc8JVZ7F3UqLS/9PTWLge0r8 DLbhLrbrfYBljqYrpfzAtbT/coHfmnA/WlkMoSOFK9Eo6kGrFS/7NZ+JcPwJt/h7/OSG E6fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=YTefPEPM; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s9si36602916pfa.282.2019.04.29.17.30.28; Mon, 29 Apr 2019 17:30:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=YTefPEPM; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729238AbfD3A1x (ORCPT + 99 others); Mon, 29 Apr 2019 20:27:53 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35874 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729214AbfD3A1x (ORCPT ); Mon, 29 Apr 2019 20:27:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rnbpRN3dar3hMqFtw7MpyRrExSiExRk5urYTkAAt6BU=; b=YTefPEPMxTD/ZjtLJweKoH7Qa KisDhWLCjoqjsnKTFZL7mG8uHi9ur/swxe9/kB/6bJmaC6arTAVM07YTec63b4wB6XHKH2RHz/9iY JJQG4AhrwPrIzaUyenGidF/lz4OLc8Kawg8pEYvgLKyWljW03YYJ0IKTb3rOmg5dey1nSi1nFwKCN BLGkJMbnvAYQVTHPthFxH/CKcXnc7ljSGx6pNJLDPjjhijY1n40Qr+4NzEig2HPslInl0XmBnF2+R nCvhNz3Ayja7QMoVtNQfR9Bn3R1B7PlCUll27UmZwwoac7aFWosyxMrqWrddTN40je59GwxJqTo91 tV0VTaCrg==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLGci-0007mB-5o; Tue, 30 Apr 2019 00:27:52 +0000 Date: Mon, 29 Apr 2019 17:27:51 -0700 From: Matthew Wilcox To: Chandan Rajendra Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, ebiggers@kernel.org, jaegeuk@kernel.org, yuchao0@huawei.com, hch@infradead.org Subject: Re: [PATCH V2 00/13] Consolidate FS read I/O callbacks code Message-ID: <20190430002751.GB13796@bombadil.infradead.org> References: <20190428043121.30925-1-chandan@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190428043121.30925-1-chandan@linux.ibm.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, Apr 28, 2019 at 10:01:08AM +0530, Chandan Rajendra wrote: > With these changes in place, the patchset changes Ext4 to use > mpage_readpage[s] instead of its own custom ext4_readpage[s]() > functions. This is done to reduce duplicity of code across FYI, "duplicity" means "lying". You meant "duplication".