Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp25943yba; Thu, 2 May 2019 18:52:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxtxRIGFz2Z3wzsAGhg78GExcVYjF68c1n1ZtYQp7wbAswwxRcewdb31uhnzNL9e8BnwF5a X-Received: by 2002:a63:f448:: with SMTP id p8mr7368528pgk.50.1556848338995; Thu, 02 May 2019 18:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556848338; cv=none; d=google.com; s=arc-20160816; b=KWXYsZVLA/8QJDk3BcY8tJ72clXeD4z7poZX3lZ2WvJL+ku8FxkZZj1K59v4cZw0oQ 7gDQBkTnG7u3CUz7u+5LTa0BXtfs6/rS5qhAbKpJZ9QkkjR8n32D0VRSbDyv6h60qAhE sOX4aRHOvcJmMgpEbJA4FCNP/0/EQFbCV++Xww5jAvqOdKgMmo/S4GsQEszohv6ENITu CbIn9Fx8Njpj3xR+UjWzMATGj51tWaSmHQHMZxPF9cfWE1AVtesP6oNgnWJLCM36ervC bl0mYRrVnwgDUaOm/Q7cnVXEMMcblQCrnRY0hmFDGoAvf3/1RqOoOjzrv5Skbfl7QZkp F2ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:organization:date:subject:cc:to :from; bh=wDw7AICPtUHpCNoZdERdnOqSWnEolQ4+evTas9yeDsk=; b=DZj/tYLDeAvFpTugV+BkyqreJKxKEO33oYw/mJdGg8+6S2Kbr5gDaaZjZ9fwNoTrka A0X9NL/+Wb62aTemZI4/eLYHzOwCMVTBSnVPlMHJIZJZROyYYqefZJAeFFLyxraeRBDM 3lfUPcSw9SU8rR3w4kq5WVZVqwwRQ4meo1v1coS3hox7mPf5uhukzavYOHJEzw8fR7kn heMGH6TkZOgpIOEufqzTn4KzHD0E69sFYMQs18JLScofLCiOkEgqrArfhbwQ+LYmvZdz /etpzbTGxI79mcPkm1nLb44EY/kuPv5dduyq7wlOBX86JOE4KPi8mvs2JAOIVW+W84i6 rEJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w14si825914ply.226.2019.05.02.18.51.54; Thu, 02 May 2019 18:52:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725995AbfECBjz (ORCPT + 99 others); Thu, 2 May 2019 21:39:55 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55302 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726128AbfECBjz (ORCPT ); Thu, 2 May 2019 21:39:55 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x431aasR079584 for ; Thu, 2 May 2019 21:39:54 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2s8bhn139r-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 02 May 2019 21:39:54 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 May 2019 02:39:52 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 3 May 2019 02:39:49 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x431dmN752625432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 May 2019 01:39:48 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 805664C04A; Fri, 3 May 2019 01:39:48 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 405C64C050; Fri, 3 May 2019 01:39:47 +0000 (GMT) Received: from localhost.localdomain (unknown [9.199.55.113]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 3 May 2019 01:39:47 +0000 (GMT) From: Chandan Rajendra To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 03/13] fscrypt: rename fscrypt_do_page_crypto() to fscrypt_crypt_block() Date: Thu, 02 May 2019 21:13:47 +0530 Organization: IBM In-Reply-To: <20190501224515.43059-4-ebiggers@kernel.org> References: <20190501224515.43059-1-ebiggers@kernel.org> <20190501224515.43059-4-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-GCONF: 00 x-cbid: 19050301-0008-0000-0000-000002E2BA70 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19050301-0009-0000-0000-0000224F2AA1 Message-Id: <3498805.PsyZfXou4z@localhost.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-03_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=695 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905030009 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thursday, May 2, 2019 4:15:05 AM IST Eric Biggers wrote: > From: Eric Biggers > > fscrypt_do_page_crypto() only does a single encryption or decryption > operation, with a single logical block number (single IV). So it > actually operates on a filesystem block, not a "page" per se. To > reflect this, rename it to fscrypt_crypt_block(). > Looks good to me, Reviewed-by: Chandan Rajendra -- chandan