Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2344956yba; Mon, 6 May 2019 04:34:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQmG9BXKwxu+uqCm8eUnfnI3sqsUPZXEiwDXSAD8Cle6qTDu8k9LDPE4jtVrxsjMWLEkIh X-Received: by 2002:a17:902:4503:: with SMTP id m3mr28922781pld.97.1557142461401; Mon, 06 May 2019 04:34:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557142461; cv=none; d=google.com; s=arc-20160816; b=uh127ZTMLs8cv6gG7/b7UWk9Z/GNPTZpcFZt5wISQId+aKCaDlzMbA6/iLcFP6Bo1r MfJiOwh9e7ugK9V8M+p2hNyKz4+u4gOFgcwVvYrZrTE2MqIe6MwPc9cBvfoXOgdE1KQl imWXS9mDKbcNBOtOWp23Ll2dBpg+yuNjR7NDJ0wswfnHoPnQ0njoH2LhPaxwv3KY4YnY vQK0bWL6o3bSQZNjI/Igy4Xnn9YLnWivIeDlFbgFdhx2UsmXCqo7COUzYDYD4AFn3V3Q qb1+8p1s+CjHwGjPoCjv3KUYwFy+sktQr8GyGrexhxhjmv8KQ6QTZNrxbkkVHhKUHd1/ MmSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:organization:date:subject:cc:to :from; bh=MDyOulEnTxxPvq/XUJA8TwTA56k9iEa5LTJIDKXAfAI=; b=MH1uRd84iX42hxnDsvnsTtCJDB2q8E1SHMik4vA3gD/+Y0I6jtkM3bLnN5nuG9x3St f4ZZb6WiiUYbvppycIQ4Q/DtnfcnP5bR3q8484dfp/hlu4Y39+sWxaKJ2dllaS95dgcN VeMeqVZ2FMeWuvk1JUD6aQF9RuJJqKg8uAyqBSmuEKuS3J9+sk+nCWa4WUadwmBbt4DL nF+hI8VmVa1+tqgGgVgRz45La61ku1uyo9JKkRlmvXzsJIZZs7HbkOznEta/c9unEoCV aWPUk6+zFvskNogrUG0tNpQJgjj8rPEclhGTfTKl1whUVXETi+4RV8yeCETAsEpOl3nz Vm/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7si2856012plt.67.2019.05.06.04.34.06; Mon, 06 May 2019 04:34:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726063AbfEFLd4 (ORCPT + 99 others); Mon, 6 May 2019 07:33:56 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46680 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725883AbfEFLd4 (ORCPT ); Mon, 6 May 2019 07:33:56 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x46BXHGf167293 for ; Mon, 6 May 2019 07:33:55 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0b-001b2d01.pphosted.com with ESMTP id 2sahndnuh0-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 May 2019 07:33:55 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 May 2019 12:33:53 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 6 May 2019 12:33:49 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x46BXmdi54722814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 May 2019 11:33:48 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 22630AE058; Mon, 6 May 2019 11:33:48 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C3A36AE045; Mon, 6 May 2019 11:33:46 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.70.42]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 6 May 2019 11:33:46 +0000 (GMT) From: Chandan Rajendra To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 13/13] ext4: encrypt only up to last block in ext4_bio_write_page() Date: Mon, 06 May 2019 14:42:14 +0530 Organization: IBM In-Reply-To: <20190501224515.43059-14-ebiggers@kernel.org> References: <20190501224515.43059-1-ebiggers@kernel.org> <20190501224515.43059-14-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-GCONF: 00 x-cbid: 19050611-4275-0000-0000-00000331DF5D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19050611-4276-0000-0000-00003841461E Message-Id: <5247310.83GBoLVoWW@dhcp-9-109-212-164> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-06_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=780 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905060102 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thursday, May 2, 2019 4:15:15 AM IST Eric Biggers wrote: > From: Eric Biggers > > As an optimization, don't encrypt blocks fully beyond i_size, since > those definitely won't need to be written out. Also add a comment. > > This is in preparation for allowing encryption on ext4 filesystems with > blocksize != PAGE_SIZE. > > This is based on work by Chandan Rajendra. > Looks good to me, Reviewed-by: Chandan Rajendra -- chandan