Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4119149yba; Tue, 7 May 2019 12:25:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqze5RqBIsKFEbU1HKgw+h6p4DPsoerxlbMd/wF16MCfu4p8z5gREBo7/Ik55ezaO3ufh7xs X-Received: by 2002:a62:d286:: with SMTP id c128mr44074646pfg.159.1557257108123; Tue, 07 May 2019 12:25:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557257108; cv=none; d=google.com; s=arc-20160816; b=rJrieK3ZdxQytFDuTI0HCQck1ESS3EQdx4KdGOfhhbl2rDhEtvv5c+gDTZggFo+9ym f8Uh/FiEsuBdTIpJFtGpIN9orQ/fpzI9NwAhumGwvnQuhDYHDqx5IjAYGchtfbLdtzMU Azg0qkExbqRXHUGPr9+bGOkOY+BuOwvKiBPIgC0bCpFD9b4d1k/dySAMs5qJ2Z+C0Rzv N6z0mQUPKEkAHWlJWS0s/ccLXjlc+sfpRklL4CPzM9rYLhmcy/aQFwKgnNSOHdXyofkx /cOgZcd3I9tr8weC3BBz/Z2y/yZ3vMNCHDzcdUe7LDBleJ30BlSlKLPZw1qbT+VSTvX3 GMCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=9VH2cI54WOtf0TgOVICv7YfH/dmJx9RgBuqx8oc1Mjk=; b=JNow1UT/A/UaH/NoaG610qHRbkbbKFAOTuCjKaXtofWrk+j+CSmNy2jdBees2prO3c owiWJHzQJ9VgdyjeKG7J6lkvPpSauMay006x+OIPZxxlxk2ZRi/F8kuTygxn/sMIcspt PdHvPbvg118C0v28XoJoJk60cNUu0pPGWcGS9cCazdAn+cdtqa9XLnwnlRLwY+YUuZ0j U+WHAmbzauIilEznSvHkpOLUPH5VK/w4lp3F+C6uy6shvqLs/ow4e+AV1F5+lldJtJLP GfMK+FK9ddsP21NhNnP3CUBU+CMzzGg1PluG3Qn5P+u3IBYLjrCHDepLSin5sVLMw6XP e0vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=F6ld+tZI; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1si7445792plb.210.2019.05.07.12.24.47; Tue, 07 May 2019 12:25:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=F6ld+tZI; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726457AbfEGTYp (ORCPT + 99 others); Tue, 7 May 2019 15:24:45 -0400 Received: from mail-lf1-f50.google.com ([209.85.167.50]:45671 "EHLO mail-lf1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726420AbfEGTYp (ORCPT ); Tue, 7 May 2019 15:24:45 -0400 Received: by mail-lf1-f50.google.com with SMTP id n22so5156735lfe.12 for ; Tue, 07 May 2019 12:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9VH2cI54WOtf0TgOVICv7YfH/dmJx9RgBuqx8oc1Mjk=; b=F6ld+tZIKD1TRL0AE6fEb2WqRxcP76uZx0RNPDleIxyf5RJkwYPqK0Bs9zD4aODmmE 4NNavp1nVKPc4olfZNB0csbl8Mt2jrfw/4cvqI1dQpb6hDyRxWSjJ7Yy4Q29HBvFbOfA JtYubFLJeY+4ZpX9T0ONIWuycTh2DIrMPc1SCGpQzEDby6c9B7ZikuGkc84pDR1T+N6M 9spwBfJp4nacEIzecHYOyudxpJIHO5m/IUkW4JFPQf66ZbDiyfZVU/nw8vjKyLhqtWer 9FWQL1ENLRVadfjFY2rI1CERtp+W1p4k6aV0bmDTRupY82fFnsyC2IcEpAqT8PcIv623 jo8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9VH2cI54WOtf0TgOVICv7YfH/dmJx9RgBuqx8oc1Mjk=; b=LA8DAwqsm+3JXspBNt9nrlzbOnGQtYQhesFBG0n23bDJS4nC9Evl/qkwDVab13iAPr TuJpXIYIHOGTVUrCebpiU9pKjdjaLFxWRrpONXFs/cqV9p0DKZnAUQ5PK/D2iYeVTPcI kHh6AVEYU9q6lPrXkhp8XPKFrI5TkrvOOwqO6YGx9ycCRUhWQnoMKxw/BxXurNGHwWCQ y1q+GHAmpn7gM919io7hCn/fnpnTf9rVPrj8iQTcAtr1OAXAQ6zZF5fu1ojdKzy1E4yn XjnNNcfzWuOSk3mPZ4gcuyXWm6Jq2z7oqSvZxwGT3ZfVH9j3kgc8H/AG9yJO8Uq/lZ44 tEvg== X-Gm-Message-State: APjAAAXjlqJOGo7IrwjPlqs79AWK5dkolmWbw2JfZgyud2gF3IN75aWY WsJU7WBzEkmJaSCBxy8fvp/CcRU266Nku5mELLy0eg== X-Received: by 2002:ac2:51a9:: with SMTP id f9mr9455271lfk.56.1557257083907; Tue, 07 May 2019 12:24:43 -0700 (PDT) MIME-Version: 1.0 References: <20190426050039.17460-1-pagupta@redhat.com> <20190426050039.17460-5-pagupta@redhat.com> In-Reply-To: <20190426050039.17460-5-pagupta@redhat.com> From: =?UTF-8?Q?Jakub_Staro=C5=84?= Date: Tue, 7 May 2019 12:24:32 -0700 Message-ID: Subject: Re: [Qemu-devel] [PATCH v7 4/6] dax: check synchronous mapping is supported To: Pankaj Gupta Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jack@suse.cz, mst@redhat.com, jasowang@redhat.com, david@fromorbit.com, lcapitulino@redhat.com, adilger.kernel@dilger.ca, zwisler@kernel.org, aarcange@redhat.com, dave.jiang@intel.com, darrick.wong@oracle.com, vishal.l.verma@intel.com, david@redhat.com, willy@infradead.org, hch@infradead.org, jmoyer@redhat.com, nilal@redhat.com, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval.shaia@oracle.com, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, kwolf@redhat.com, tytso@mit.edu, xiaoguangrong.eric@gmail.com, cohuck@redhat.com, rjw@rjwysocki.net, imammedo@redhat.com, Stephen Barber Content-Type: text/plain; charset="UTF-8" Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Pankaj Gupta Date: Thu, Apr 25, 2019 at 10:00 PM > +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma, > + struct dax_device *dax_dev) > +{ > + return !(vma->flags & VM_SYNC); > +} Shouldn't it be rather `return !(vma->vm_flags & VM_SYNC);`? There is no field named `flags` in `struct vm_area_struct`. Thank you, Jakub