Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Gabriel Krisman Bertazi <krisman@collabora.com>
To:     "Theodore Ts'o" <tytso@mit.edu>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] unicode: add missing check for an error return from utf8lookup()
Organization: Collabora
References: <20190512085752.1791-1-tytso@mit.edu>
Date:   Sun, 12 May 2019 17:18:20 -0400
In-Reply-To: <20190512085752.1791-1-tytso@mit.edu> (Theodore Ts'o's message of
        "Sun, 12 May 2019 04:57:52 -0400")
Message-ID: <85lfzbbcdf.fsf@collabora.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

"Theodore Ts'o" <tytso@mit.edu> writes:

> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: Gabriel Krisman Bertazi <krisman@collabora.com>

Acked-by: Gabriel Krisman Bertazi <krisman@collabora.com>

> ---
>  fs/unicode/utf8-norm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/unicode/utf8-norm.c b/fs/unicode/utf8-norm.c
> index 20d440c3f2db..801ed6d2ea37 100644
> --- a/fs/unicode/utf8-norm.c
> +++ b/fs/unicode/utf8-norm.c
> @@ -714,6 +714,8 @@ int utf8byte(struct utf8cursor *u8c)
>  			}
>  
>  			leaf = utf8lookup(u8c->data, u8c->hangul, u8c->s);
> +			if (!leaf)
> +				return -1;
>  			ccc = LEAF_CCC(leaf);
>  		}

-- 
Gabriel Krisman Bertazi