Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4663216ybi; Tue, 11 Jun 2019 10:18:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqziP1w4vXwi3pWTSphsiW49AMF+zex7yTh0uNo2j1q4DqDrTyKorPQU86rNlNzrbLJ0ky8p X-Received: by 2002:a63:6c87:: with SMTP id h129mr21699010pgc.427.1560273517127; Tue, 11 Jun 2019 10:18:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560273517; cv=none; d=google.com; s=arc-20160816; b=BNf99DuHpZMKtaGkuEb84oZaFkErzN6rhYAXx27l5eGcj2hYd299s9mIS/C0bk7E4K 2KmBhxwjPzdH5reL5cKTHp8aQSxZX04SRlnv3OnIIztN6Oh3nGo+cSJxlimHUI/sFLV3 gfTXtMyHRhn/ggUJkakeHUjl3OG6UuqtiS4idol2QfnKevpEzL4S5b9wH1EboRBhvTmX MGHHGi1Ov2C5KdAWIiv+f5O1SDSzKWIo8+yPOoIfswqSJarFfh2IWbQTU7uVHHihIfRa WZs77tYqFaOr9L5xziG5umnbiXz51B7P4ZXZlgxZo+XaXuksnq2uswZ1Aicbc+kfvpPV 1cnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=DVTxcv0nsxD4O7k8qChKP0RnB50xXB8H0tvR+SRWMXM=; b=bzML6L3t+gvl48XpKRRKrY72AdX3w5Uoomtxi5kd7P23I/UIkY1C6Kh5PiPBIOagKG KW6BQQrkWfAA33rCpwnYiGEq4NRnSerNu0HMRYCNeeSGgqPjHhwK7eN8eeEuFgX5t8WI fLCxMCXjqskuTlsbCnZOfGRZ9KIrv8ZXoAhFDfl3ACHzIoShjAyuR+AajVGKQc6ZtsPG QzWnGSpn6o0sXZEozexXM4cRC6ZynX42ahnHlGHbEIRPSxMGMsW5aR0viXqrZcYWT0Gr 0fk0rJDEP7QTy/Auytjr3R6y9bAczBmX2EXRVeGny6YCECV/QatYG1AnLtVecbrN7rPp Uiug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b69si2838784pjc.104.2019.06.11.10.18.21; Tue, 11 Jun 2019 10:18:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405686AbfFKROq (ORCPT + 99 others); Tue, 11 Jun 2019 13:14:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40278 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405627AbfFKROq (ORCPT ); Tue, 11 Jun 2019 13:14:46 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A50D081112; Tue, 11 Jun 2019 17:14:34 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F196A60143; Tue, 11 Jun 2019 17:14:17 +0000 (UTC) Date: Tue, 11 Jun 2019 13:14:17 -0400 From: Mike Snitzer To: Pankaj Gupta Cc: dm-devel@redhat.com, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, dan.j.williams@intel.com, zwisler@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, mst@redhat.com, jasowang@redhat.com, willy@infradead.org, rjw@rjwysocki.net, hch@infradead.org, lenb@kernel.org, jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, darrick.wong@oracle.com, lcapitulino@redhat.com, kwolf@redhat.com, imammedo@redhat.com, jmoyer@redhat.com, nilal@redhat.com, riel@surriel.com, stefanha@redhat.com, aarcange@redhat.com, david@redhat.com, david@fromorbit.com, cohuck@redhat.com, xiaoguangrong.eric@gmail.com, pbonzini@redhat.com, yuval.shaia@oracle.com, kilobyte@angband.pl, jstaron@google.com, rdunlap@infradead.org Subject: Re: [PATCH v12 4/7] dm: enable synchronous dax Message-ID: <20190611171416.GA1248@redhat.com> References: <20190611163802.25352-1-pagupta@redhat.com> <20190611163802.25352-5-pagupta@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611163802.25352-5-pagupta@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 11 Jun 2019 17:14:45 +0000 (UTC) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jun 11 2019 at 12:37pm -0400, Pankaj Gupta wrote: > This patch sets dax device 'DAXDEV_SYNC' flag if all the target > devices of device mapper support synchrononous DAX. If device > mapper consists of both synchronous and asynchronous dax devices, > we don't set 'DAXDEV_SYNC' flag. > > 'dm_table_supports_dax' is refactored to pass 'iterate_devices_fn' > as argument so that the callers can pass the appropriate functions. > > Suggested-by: Mike Snitzer > Signed-off-by: Pankaj Gupta Thanks, and for the benefit of others, passing function pointers like this is perfectly fine IMHO because this code is _not_ in the fast path. These methods are only for device creation. Reviewed-by: Mike Snitzer