Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1442393ybi; Wed, 19 Jun 2019 21:02:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnB2fGKJS0TuJVwPldCynbQHuN98KrtQLaOQ0cL38gx2XXwR1HdYl5lv8Q9GvZ5PcP3FWt X-Received: by 2002:a63:2206:: with SMTP id i6mr11264872pgi.349.1561003343306; Wed, 19 Jun 2019 21:02:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561003343; cv=none; d=google.com; s=arc-20160816; b=Kz8i2UIWBmRrvmRk8arYg08evR3K5jwbrbnQzJklt0KpvSRrEBr6epv38fNOSor9wz /Z51j61uB6wB/nCDGUPQL+Ehr6l1WVedyUFblHuwZ4iN8lU/NaBJ0Fxt63weQRV13wrD 3jz1DC87ctB++5+UQx9T0snLgsTwNq0MMO2U+pzZpqqvpWkesXw/bIMJlS2TcaLadgTx HCijpUXhwTLoChhw+ocHM1yMsbFYbGxc3COBkvEhj5l4tx0TVBr6yjDdO99BbGZnrB/4 BIWdjYBIQRjX2dJGT4tdz50BfFk2Yy8UY63woVV2ug5txbn0l2shGQYP1+R7csmHUzS5 M+Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/NP/fJSqyBMGymS9Qakea2RldpKPxTk3WjoReZ17Z5g=; b=emHkqgRA3e8qfeknCQKPwom98bEFWwbNuYnna8pNRMpTH4AAHQsb3rtlVKw3HMdY7I L2NWXtxSIHcp0jSW80fdNFSkg+JM1SLtnR1O7+IFvDW0gyaaCh8yFV6iWUZOmnLRvVfA XU9Iv6T+0jeo1nEdKaaS3ErOdcODX/Aws8PRl8WNUBbtAfFD0ByMiItbbuPVb4UdcgjL 6hb64FOwGk3MYjqs+5Jh2KpdrjvE2mG2AP5Aq0Lcucu8zwfKcVa8tGTTE1KUh1zfuF8o baj8Y9oU8Q7P05wzMe2tmWzdesSEf7+NlmmG/bVbYrXu5hkAXLXXRZtAyFUriYOp0A3o ClqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21si4805629pgf.268.2019.06.19.21.02.03; Wed, 19 Jun 2019 21:02:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725875AbfFTECB (ORCPT + 99 others); Thu, 20 Jun 2019 00:02:01 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:45909 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725857AbfFTECB (ORCPT ); Thu, 20 Jun 2019 00:02:01 -0400 Received: from callcc.thunk.org ([66.31.38.53]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x5K41u2f005812 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jun 2019 00:01:57 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 5CE5A420484; Thu, 20 Jun 2019 00:01:56 -0400 (EDT) Date: Thu, 20 Jun 2019 00:01:56 -0400 From: "Theodore Ts'o" To: Gabriel Krisman Bertazi Cc: linux-ext4@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] ext4: Optimize case-insensitive lookups Message-ID: <20190620040156.GB15783@mit.edu> References: <20190617190240.30996-1-krisman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190617190240.30996-1-krisman@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jun 17, 2019 at 03:02:40PM -0400, Gabriel Krisman Bertazi wrote: > Temporarily cache a casefolded version of the file name under lookup in > ext4_filename, to avoid repeatedly casefolding it. I got up to 30% > speedup on lookups of large directories (>100k entries), depending on > the length of the string under lookup. > > v2: > - Dinamically allocate space for the casefolded version. > > Signed-off-by: Gabriel Krisman Bertazi Thanks, applied. - Ted