Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp122872ybi; Tue, 2 Jul 2019 17:28:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwhdmOptw/AvJnms+0IaW++1qYb/K0/66z9FQHEke2Y4ZsaROhVTjLIo94aSWcwLwNZOPx5 X-Received: by 2002:a17:902:7586:: with SMTP id j6mr39082567pll.128.1562113705144; Tue, 02 Jul 2019 17:28:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562113705; cv=none; d=google.com; s=arc-20160816; b=sEUE7wAdMM7kSw+5Duv+SQY5kb3IipMwRicdo5x1TJtzo1WtLpLrTQLqRmABzvvHeO f4gO7RoLB284CIT3GyTbXuH4/dvFgAahlT9cEstdItBWBrcimh5p7+lTapmKaneTtqO7 /vP73XMG2Eg/MG7RJP+d7eLnsuhWQtQuiElNSkYDvm4dfvl3XQHOD255XDPRFDJbn7iB NImUo42ggcU14b+beBXtl2UQP1++j4CiQH1k+YfyqY8eaCQGSEpcmialD2bB3SCXk4Bx l6OZp0RQUJbij6kXB96REPCNy+gHnlhdPf3QgRgX6+RSCipgt0QcZbkET5TFwK21jhWZ bdKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+4AhXRvCIK6Geq3YW7DOWjeQx7N3usHazq0OUH+tOy8=; b=giF65hsvYirWrcjiAGcpTptI8+scD8W42YZT7pJc0sVaQvvsYPqcBe9Hms9RRWtFDI BdDSCOsQWeLMk3nK+5Oowl3G0yxbsAJrWuc2Qx7TuCpuEOHVM7MQ5cEcyhy6b630XN/c 5SeQGaBXzafTupvwNxqjzMM2lX2sF65njgq83tu/f6tF/IrtRvt3WzzavXbG6Uxk9Bgy zjLIKWUHB2kxrwWDv8CgemqFGTnm8E/jD2gp0/oJFDH/cQugfDemM2PsqNXMsVmrA1cu f1NtcC2fqcr6P8TpHw0Iwr/J1bg957wxC24w4V3yHK6KPbK9/TPy59MbV50+XBadj/u5 PSoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q66si162183pjq.109.2019.07.02.17.27.58; Tue, 02 Jul 2019 17:28:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726963AbfGCA1f (ORCPT + 99 others); Tue, 2 Jul 2019 20:27:35 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:32964 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726291AbfGCA1f (ORCPT ); Tue, 2 Jul 2019 20:27:35 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-109.corp.google.com [104.133.0.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x62LvS8G031701 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 2 Jul 2019 17:57:29 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 8CE0E42002E; Tue, 2 Jul 2019 17:57:28 -0400 (EDT) Date: Tue, 2 Jul 2019 17:57:28 -0400 From: "Theodore Ts'o" To: Gabriel Krisman Bertazi Cc: Dan Carpenter , linux-ext4@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH] ext4: Fix coverity warning on error path of filename setup Message-ID: <20190702215728.GI3032@mit.edu> References: <20190624122906.GA30836@mwanda> <85r27dlay3.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85r27dlay3.fsf@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Jun 28, 2019 at 04:19:32PM -0400, Gabriel Krisman Bertazi wrote: > Dan Carpenter writes: > > > Hello Gabriel Krisman Bertazi, > > > > The patch 3ae72562ad91: "ext4: optimize case-insensitive lookups" > > from Jun 19, 2019, leads to the following static checker warning: > > Hi, > > The patch below should fix this issue. > > -- >8 -- > Subject: [PATCH] ext4: Fix coverity warning on error path of filename setup > > Fix the following coverity warning reported by Dan Carpenter: > > fs/ext4/namei.c:1311 ext4_fname_setup_ci_filename() > warn: 'cf_name->len' unsigned <= 0 > > Fixes: 3ae72562ad91 ("ext4: optimize case-insensitive lookups") > Signed-off-by: Gabriel Krisman Bertazi > Reported-by: Dan Carpenter Applied, thanks. - Ted