Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp123091ybi; Tue, 2 Jul 2019 17:28:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzL6m4Psj2ji5URV2/nr44zL3kOPZF4Kub5RfRpwWxDmVQR4MgxCdIf9ygPR74RbYID3BHU X-Received: by 2002:a17:902:968d:: with SMTP id n13mr38815603plp.257.1562113722538; Tue, 02 Jul 2019 17:28:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562113722; cv=none; d=google.com; s=arc-20160816; b=ZIn0XHCqvt/gxpyHlloCR9TmrXxQBCfJwD6+ffDbSmJQK2QMB1quPqrfGzlNzMe2M7 vrfOtC8rsIxhDMIi4qcOI2EjGl3N05aKreRcNAiW4wozKU1VkIa7LSxEykd8HVpzqqIx iWJrezr+EZ3a2L6Ob6t8rZG1LNtoXc9dTWa3Qpfnlnf2DTtHe6b2i17BXAEc2Nwuo3xV Y6lFrnhab6TDxJqKywxpFrtzpJrOOOl1+3mDbLyG9upE8n+JYB1d3JG3pXDGbclrcAK+ /18ROnN5MKjFop0KQEmyslcUY0PHnXqBWgdCZIBJsEtpUURnvC/maHaABlNdVeq8XJpF FPfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date; bh=tazkirmQO2qmzWc2zD4rRnb8BJbjLkkcrzVbsb+p4Wc=; b=u9BzUS4AcJijOZzaKjf2OVg+9a4vosGeQx6vbhsuA2PCvyWRT1jjp8I//pPBoS1KP4 6e8CVW2wQpgl0ir35JOAZo31Y6xOlBbdu3BRbPa5HDJBiN1vQx2b02O4LylqHI7qQ41W A5TNZZQuPJaFi/DqMeM8qgcxBmpaL12ctcdEtlvSVbSILQPyIfPz9posBTuaUf5LBkjM a3VFWFjvN2ay0V+/lh7Uc6UKL40loXG+JJ/dpe7FLJY2P7DpoxPT6ro87MpT/aEeTaaM PU06cgPNKEAGSm30WbVAzEZJeluKfp76LBbQGewh8W4MINvrtOSCloUIu6hsGMOkAtN0 5qYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r19si324387pgl.203.2019.07.02.17.28.28; Tue, 02 Jul 2019 17:28:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727169AbfGCA1f (ORCPT + 99 others); Tue, 2 Jul 2019 20:27:35 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:32965 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726150AbfGCA1f (ORCPT ); Tue, 2 Jul 2019 20:27:35 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-109.corp.google.com [104.133.0.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x62Lfp30025320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 2 Jul 2019 17:41:52 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 65FDB42002E; Tue, 2 Jul 2019 17:41:51 -0400 (EDT) Date: Tue, 2 Jul 2019 17:41:51 -0400 From: "Theodore Ts'o" To: Kimberly Brown Cc: adilger.kernel@dilger.ca, gregkh@linuxfoundation.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: replace ktype default_attrs with default_groups Message-ID: <20190702214151.GA28833@mit.edu> Mail-Followup-To: Theodore Ts'o , Kimberly Brown , adilger.kernel@dilger.ca, gregkh@linuxfoundation.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190508200748.3907-1-kimbrownkd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190508200748.3907-1-kimbrownkd@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, May 08, 2019 at 04:07:48PM -0400, Kimberly Brown wrote: > The kobj_type default_attrs field is being replaced by the > default_groups field. Replace the default_attrs field in ext4_sb_ktype > and ext4_feat_ktype with default_groups. Use the ATTRIBUTE_GROUPS macro > to create ext4_groups and ext4_feat_groups. > > Signed-off-by: Kimberly Brown > --- > > This patch depends on a patch in the driver-core tree: > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=aa30f47cf666111f6bbfd15f290a27e8a7b9d854 > > Greg KH can take this patch through the driver-core tree, or this patch > can wait a release cycle and go through the subsystem's tree, whichever > the subsystem maintainer is more comfortable with. Thanks, since that commit is in 5.2-rc2, I've applied this patch. - Ted