Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2432885ybi; Thu, 18 Jul 2019 08:18:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwi4vxb4nX00uQQ1oZfX24TrHHHv9DaYn1Ml+h0dThevu4iDOhTDdUGMZWVq3MtH7Z0fxh4 X-Received: by 2002:a17:902:9346:: with SMTP id g6mr50508459plp.61.1563463100938; Thu, 18 Jul 2019 08:18:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563463100; cv=none; d=google.com; s=arc-20160816; b=EbcWNQKp3bbG/X/jaCbh70XCBzTohN4lI/1tuZXJUmbb3BgbPqdhcVvEjF5b/3wIXk CTa9+rxu/quzZQIWEu25fN/3vuSPXO9yWv9Yop3VQPfA8JaQyhPVH6ZzX8tCkB4adjs/ +kcs1X2a2gGlKcVdYSS3cSqUmBSrjKW86dbkXLMxH/FJWi6p15OxR1v3lafL4SkUX6xY 4pGcRv4AtR3bOW/xrTXPT8df23PMJyDZ8pRZGW2zx5B9xft4eqBs1LClGvwurqxvZR/U 8NjPwP61JMUpliywMPqyrP6ApN6IJdSUTmnDf8unwtdDjA/jx2NY7ayCtyo9Z3mc211I ilFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date; bh=xJWRqj3Qt7Q0NJkkb21Kjg8typL1TCSKAv0I+8bnp4M=; b=0qMn3oPYOkb5BF2ut5KdzSOAscI4sEsqSOTn1fxAmM1o+HTmoDF08xEPOEktqhDrQy TXkdTCTUWVPEewOiedWuKZBLveRS16hQ47/UoiArkbsRPBDxppx/3vcZ5tYIufjUPmNI VIMtVARw1wwMoznL9TzU9wjMhjKZ4M7ctQ8omMr7K96W58/BhSls4Dkv4XEuLKcFd41O 2O9hYdsVdA9HBbiMAU2gkhJ0UHMpSA6v08eznnDWm7Y9qLRgvAJ81noHgdnGp2WgKzJ+ JHl/Ti2Wb8Ecw+kcmbHtltthDw2sXg132xRhnUvXvtcSLG+oEdUJCVt/QyEFPOH5/IlW GCiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 10si19032627pgp.78.2019.07.18.08.18.01; Thu, 18 Jul 2019 08:18:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727911AbfGRPRj (ORCPT + 99 others); Thu, 18 Jul 2019 11:17:39 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:43365 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727685AbfGRPRj (ORCPT ); Thu, 18 Jul 2019 11:17:39 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-99.corp.google.com [104.133.0.99] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x6IFHX1a026288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 11:17:34 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 11A92420054; Thu, 18 Jul 2019 11:17:33 -0400 (EDT) Date: Thu, 18 Jul 2019 11:17:33 -0400 From: "Theodore Y. Ts'o" To: Shi Siyuan Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, shisiyuan Subject: Re: [PATCH] ext4: remove unnecessary error check Message-ID: <20190718151732.GA19119@mit.edu> Mail-Followup-To: "Theodore Y. Ts'o" , Shi Siyuan , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, shisiyuan References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jul 03, 2019 at 04:16:54PM +0800, Shi Siyuan wrote: > From: shisiyuan > > Remove unnecessary error check in ext4_file_write_iter(), > because this check will be done in upcoming later function -- > ext4_write_checks() -> generic_write_checks() > > Change-Id: I7b0ab27f693a50765c15b5eaa3f4e7c38f42e01e > Signed-off-by: shisiyuan Thanks, applied. - Ted