Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <BC4620C8-1AC6-4543-BBE8-012067ED3CEA@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_716BE7DA-4A72-4D29-A629-E9F1621C9D99";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v2 08/12] ext4: track changed files for fast commit
Date:   Fri, 9 Aug 2019 15:46:18 -0600
In-Reply-To: <20190809034552.148629-9-harshadshirwadkar@gmail.com>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>
To:     Harshad Shirwadkar <harshadshirwadkar@gmail.com>
References: <20190809034552.148629-1-harshadshirwadkar@gmail.com>
 <20190809034552.148629-9-harshadshirwadkar@gmail.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_716BE7DA-4A72-4D29-A629-E9F1621C9D99
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Aug 8, 2019, at 9:45 PM, Harshad Shirwadkar =
<harshadshirwadkar@gmail.com> wrote:
>=20
> For fast commit, we need to remember all the files that have changed
> since last fast commit / full commit. For changes that are fast commit
> incompatible, we mark the file system fast commit incompatible. This
> patch adds code to either remember files that have changed or to mark
> ext4 as fast commit ineligible. We inspect every ext4_mark_inode_dirty
> calls and decide whether that particular file change is fast
> compatible or not.
>=20
> Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>

Some minor code style cleanups.

> @@ -759,6 +761,8 @@ int ext4_write_inline_data_end(struct inode =
*inode, loff_t pos, unsigned len,
>=20
> 	ext4_write_unlock_xattr(inode, &no_expand);
> 	brelse(iloc.bh);
> +	ext4_fc_enqueue_inode(ext4_journal_current_handle(),
> +					   inode);

(style) "inode" doesn't need to be split to a separate line

> 	mark_inode_dirty(inode);
> out:
> 	return copied;
> @@ -974,6 +978,8 @@ int ext4_da_write_inline_data_end(struct inode =
*inode, loff_t pos,
> 	 * ordering of page lock and transaction start for journaling
> 	 * filesystems.
> 	 */
> +	ext4_fc_enqueue_inode(ext4_journal_current_handle(),
> +					   inode);

(style) "inode" doesn't need to be split to a separate line

> @@ -5697,6 +5719,8 @@ int ext4_setattr(struct dentry *dentry, struct =
iattr *attr)
>=20
> 	if (!error) {
> 		setattr_copy(inode, attr);
> +		ext4_fc_enqueue_inode(ext4_journal_current_handle(),
> +						   inode);

(style) "inode" doesn't need to be split to a separate line

> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0b833e9b61c1..c7bb52bdaf6e 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1129,6 +1129,16 @@ static void ext4_destroy_inode(struct inode =
*inode)
> 				true);
> 		dump_stack();
> 	}
> +	if (!list_empty(&(EXT4_I(inode)->i_fc_list))) {
> +#ifdef EXT4FS_DEBUG
> +		if (EXT4_SB(inode->i_sb)->s_fc_eligible) {
> +			pr_warn("%s: INODE %ld in FC List with FC =
allowd",
> +				__func__, inode->i_ino);

(style) this should use ext4fs_debug(), since pr_warn() is not really
used in the ext4 code

> +			dump_stack();
> +		}
> +#endif
> +		ext4_fc_del(inode);
> +	}
> }


Cheers, Andreas


--Apple-Mail=_716BE7DA-4A72-4D29-A629-E9F1621C9D99
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl1N6asACgkQcqXauRfM
H+DIBQ//XFdCCI13Uj22Ab5TuuwG+MF/TTGvwZXQTMqWaDHjQrGnUHdph/Fmn8rG
1QOSUMdbFvLrYKpIwDKi+aa29H8Cxlmju3s/Zz8IMsmhE9n54XWJdIFR6esGT4jr
79Fl2pxnYrWcTe8LeiuHLF7yRPUAKPZlo+Cv1tspfbPDL1iOZHv3SO7NeqGTr3pW
KtRLBNS5w0eCfFgs0T/LJXI8ONfx+UvzF4kAzWeb/Rmi4qIKdReNmpSrRHGG5J6R
xljaWfvLbhITVXeBqR4FspnnIwltD9YSB1XdKsgmIROlJ5FX6+vKjY5BA8ZzqpeK
yJj4KJSg0KYhveUV4HCLqWyjzTqnmoF9jtWgplwrzGFYhcMgbv2D2KoiwAZ+cVQ4
iX/HKL3SRt1/Pky8s1z4N0Bf4/YDliKO1vEPV7BYMv5aQ1iIhAPceFbD1ns1wKGt
zjqGXULrcLDcE/s/O6Q2T6FInRuuY+ipZ34i0/sf/z8fgD7JTcQwt+jq2BOJn9Cy
phOIxxBYiKuHlEUITDZNBeJ6bwjWqb3CgSay68ryfyrzwT+XafkwQxlFwwwCZJ02
B4tBWiusG4g+uwxloZ3SskFXxhY1Act4AUAN/nEsE3bAKjoQaqtot0+aS6fDGDjs
/4L5JziObzvgHKoO+hHzLvp5xdxyk0qjOC+6h20z7ZfMVmOXKK4=
=HRMy
-----END PGP SIGNATURE-----

--Apple-Mail=_716BE7DA-4A72-4D29-A629-E9F1621C9D99--