Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3849203ybl; Mon, 12 Aug 2019 07:24:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxwMLqCVNm/aXOh4lHotloz4Iau1PufzvnGDFBRoeUU0PixO6TPbw4eML288sDxf6frCOPy X-Received: by 2002:a17:90a:6d43:: with SMTP id z61mr13106971pjj.32.1565619874726; Mon, 12 Aug 2019 07:24:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565619874; cv=none; d=google.com; s=arc-20160816; b=w8w7v5g9lJewuXUnbp7dBxLfYP0AsKaXpnjZ/HgTftgP+4PsFPrm4K8JPPyOBrLpbh ewqwm+mxKO+WW+ZSbQzIRvAFrXQ06Dy1rfBcWNXkLIUf6gceW8h3NJ6P8QpEzZFM3U5q 2dmKssggOWKtFXQ5jT2avH60nlwUj4eNilmdeFqS3yM5+WbuDAD/wH4jr42eVQN+wIrV ranDzxKXhWbQ44mz2umWrmI5aoj45/9hu9Fp9l7b2SvlbEmj7XeAHmualCk9lV5KUYuC pdroFnL+8QArR3oGrgWMtvddI5/LjJG/3CMrgYKrg/2Q0sTOukivWMFegKnjLE5x3pTh e/1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=K90mqgbt1vnUHf5V/OhHoGOwagRqVKbGv8b/Icyx5zk=; b=SjXdf0lZvZsO9DGvMZ4m06qePwl90/6wsENJlD/SDXYcCq7NdEeOMLHOdFjdAFerK1 ZOb6J2gc/n+SScjJKxfhyHJK2130xkxU2HdJNjcgjBpUFbs9+s8N+ZIfX+lIM/+vHf9x zlXQ2KkoQTPRAE+nSUZFbx3C4r9vpY6upPBvD5bxkqYNecGE8P2Htn7yvOzvRwTOpfQM j3cbEWCYSQMxVCN59hIsP0k3E30REqCNu0dh7ytLyGiPgdEWEtZ2mwYXd7Lw0xpAeVzf SK33JRltMEUCUWhLy0SJ0HCaBes2e/5FuhQ/dZHv1SI+H31gopvXVW58SntHLRNPM/RO olRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 38si6171670pln.426.2019.08.12.07.24.19; Mon, 12 Aug 2019 07:24:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbfHLOXA (ORCPT + 99 others); Mon, 12 Aug 2019 10:23:00 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:35208 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726702AbfHLOW7 (ORCPT ); Mon, 12 Aug 2019 10:22:59 -0400 Received: from callcc.thunk.org (guestnat-104-133-9-109.corp.google.com [104.133.9.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x7CEMssF015720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Aug 2019 10:22:56 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 775014218EF; Mon, 12 Aug 2019 10:22:54 -0400 (EDT) Date: Mon, 12 Aug 2019 10:22:54 -0400 From: "Theodore Y. Ts'o" To: Harshad Shirwadkar Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH v2 01/12] ext4: add handling for extended mount options Message-ID: <20190812142254.GB11831@mit.edu> References: <20190809034552.148629-1-harshadshirwadkar@gmail.com> <20190809034552.148629-2-harshadshirwadkar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190809034552.148629-2-harshadshirwadkar@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Aug 08, 2019 at 08:45:41PM -0700, Harshad Shirwadkar wrote: > We are running out of mount option bits. This patch adds handling for > using s_mount_opt2 and also adds ability to turn on / off the fast > commit feature. In order to use fast commits, new version e2fsprogs > needs to set the fast feature commit flag. This also makes sure that > we have fast commit compatible e2fsprogs before starting to use the > feature. Mount flag "no_fastcommit", introuced in this patch, can be > passed to disable the feature at mount time. > > Signed-off-by: Harshad Shirwadkar Looks good: Reviewed-by: Theodore Ts'o - Ted