Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp910406ybl; Wed, 14 Aug 2019 07:51:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqw0ron86sYtQ+6SGr4ohFfQd5n0xr9KLSFbG2zno0suaiQ1GKrX5Zk/1w8zRyLguDBSdqH/ X-Received: by 2002:a17:90a:30e6:: with SMTP id h93mr126214pjb.37.1565794264469; Wed, 14 Aug 2019 07:51:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565794264; cv=none; d=google.com; s=arc-20160816; b=ftqr2WWz+6KKFzInGYmTBnD95mVpwY5lWg6YzERmlZvG/azAkxHpu/mKFnT+ruux7Z GKMsJBVBxPh1gfpLcilNFrrvM6ziOhn4nhyITBwMD/E5YpjJqS2KBlmp9mf1dGAqc27J DGi5PH86U81CTmzil5f/dKZhcvEPD2+fOljjPvnls6YatCVZhVPT8gd3wo4hZHC0oMi2 o+ew0ybtY3PPjZ8dJ7ZaFW60IIGS/dK3qmBzegyqn+X+Ws7iH6Al3TrU/RxW72IuVhQY RtX7gCBJs6Zc8D3PjczjK/IgEzM9xiM5WWwcOS2t2yZVCgz4GOM8J58pbiIiytuN4riK uAjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=cWx0cFqnOpCViIJ4tMHIiuLTvCAxlz9fs3eE3H38dRE=; b=nCFC2ljU6t7AObPtAVsOs+Y1XFSAIvaA9wx2w6QPtKOX7u+XH1PoKKyYvxed3cUEVC +TNX72+qSKCtBQECrP2jHLGsZ+ED08GWjujwdJkPKrnbC7FfqZjKLuObIt0Bze1c8RyK jjxvCZGF3GlOfx+K4JYMu4gH10QQ1HdfZ/vKLfj1DdcKZjXHHEGHKhU8Cs2UTn1CPqe6 qWS8cstfPX6s5F6TyiPSoYOpbN92S3ra2ZuI25Z9rd4ttM0/Br5AWABHMJHIFi49FOm5 HgQvg/HYV059zI1XGLi766dBDds9idW0/oWEhrSiKBPAPseloQjlgInVPuQ8YRI7q+NV xuzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=lXrxUu2G; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a64si7627pla.432.2019.08.14.07.50.43; Wed, 14 Aug 2019 07:51:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=lXrxUu2G; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725955AbfHNOug (ORCPT + 99 others); Wed, 14 Aug 2019 10:50:36 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:40724 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbfHNOug (ORCPT ); Wed, 14 Aug 2019 10:50:36 -0400 Received: by mail-ot1-f66.google.com with SMTP id c34so42950944otb.7 for ; Wed, 14 Aug 2019 07:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cWx0cFqnOpCViIJ4tMHIiuLTvCAxlz9fs3eE3H38dRE=; b=lXrxUu2GbQ/3WBKNQg6bGoE9vwtRUCP4SFYSH0scEDD89DaRziNNmLBjE0vttmjUe/ O4oi/JbfzfFG5Xw+9gyej9xa8Hxo6VT5l/5Uhu6Ny65juAt0JRUAzvszKia3iSP6nh2r cE0Ny9xPzGSah2fDAN6DN8EjpM8B6mh5i7nhJfiWPFDueWS5tsen90BhvNf8os6QfOaB R9wxOqDAIO9Yz9t6d1bMDRQ3gDdzZeohh4mmfilwhiOUUe/mDlQ6e3WFeK9AEwQGx/YF rY1tFBsimehN69v0SOIHFcLiMcb9eRNPzSfZvNrcyjLsWDG+3r2rJKdeGRUyQs6JW23U vFbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cWx0cFqnOpCViIJ4tMHIiuLTvCAxlz9fs3eE3H38dRE=; b=jSWGM9qCeuucbR/QEhj8aHi1o206cMJx4XOwmREWtgbBwZtu2XmHkkfjpZfGcR9/Ur JXi3gV9Wg5+pA+gRK77FO2ACG1OztUcQeKXBvbuMSx/gOCnnLlsFCSgrznt5nXFEXvZ/ S2ewLaCZP7gV338dio07pV3XcOghinbZmEqA9FB31e4fjf1tXa+25mnde5QR5apyy/TG E9I4OvOLnPa5500VjsDirw0Z2jKsozpPC9HvuicSRs/w87pNgVEq4OG9JspPWYZsx3Fn RWKuWY3RxzyVqHKp3DP8nl31tMi3Ar0MwIhTUwGTSnPidGBz2jykRfiq6xe4dn4jqFCB hOvA== X-Gm-Message-State: APjAAAU509ofTdu1wQaUBi7/6aTNUy6jib6GIbMZbHaw+f55sCR9EKaw xPNaYOWHZ8uapcF8urk/N31cYA== X-Received: by 2002:a5e:834d:: with SMTP id y13mr288968iom.79.1565794234700; Wed, 14 Aug 2019 07:50:34 -0700 (PDT) Received: from [192.168.1.50] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id e22sm101663iog.2.2019.08.14.07.50.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 07:50:33 -0700 (PDT) Subject: Re: [PATCH RESEND] block: annotate refault stalls from IO submission To: Johannes Weiner Cc: Dave Chinner , Andrew Morton , linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190808190300.GA9067@cmpxchg.org> From: Jens Axboe Message-ID: <4ad47b61-e917-16cc-95a0-18e070b6b4e0@kernel.dk> Date: Wed, 14 Aug 2019 08:50:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190808190300.GA9067@cmpxchg.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 8/8/19 1:03 PM, Johannes Weiner wrote: > psi tracks the time tasks wait for refaulting pages to become > uptodate, but it does not track the time spent submitting the IO. The > submission part can be significant if backing storage is contended or > when cgroup throttling (io.latency) is in effect - a lot of time is > spent in submit_bio(). In that case, we underreport memory pressure. > > Annotate submit_bio() to account submission time as memory stall when > the bio is reading userspace workingset pages. Applied for 5.4. -- Jens Axboe