Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp416254ybl; Fri, 23 Aug 2019 02:52:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqwE1VdhSUeaeys3vxrNL4JvmGukY82ogGupyi8FuRuLO1dEFcOvsPplw2uQxRrbqJyEon/d X-Received: by 2002:a17:902:54d:: with SMTP id 71mr3684991plf.140.1566553924762; Fri, 23 Aug 2019 02:52:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566553924; cv=none; d=google.com; s=arc-20160816; b=QHxoobrgkp0Id4vxqPAVmhzEHyrNULPqHBt9aiutIABtGsVE6HVLAJC1hmz4xe7JiR lQLN7U5C3HlgUtvlJ/gkhtaGR8wjFZSoCN3V2OgK5HZMkc4J+6R/iXISF29nuZqbD0n1 qHuqEBSwNi1pUv5SqovYUvhaKUvuxGYTXNxGHAHgboeGBIE30Z1TN/px+yuz2aCnRp7g xnDyR+Y54/0b9DKwFggzHmEahwbSZJ6JdMxSfkN7J3Sp55MtjwoQVzQJkqLmhxyY7BjV oXMIZrBrDHcveiQyCAbAo8a0OnLa1qqodBG0ACy/t8lLdJw2wtlSApKs/jHWR3CzA6U1 6o4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date; bh=wukw72tseRVHgh17m0VdJEwQ3bZtmS5nwIEIIui6TiI=; b=m5jR0ak6gb4q/sYkPzQmkCmhy5Q1ZynC/oXZDNifoQGppjxMsw52Khs38hHQru9eMt rwXzV3omLFWhog/3mPB1YLDZFWeISixhNUAtQ6qnBSo3ooUw6OsE+gN6jmJOdEOEWu0k 1P0WhHHI2Xw046FDI5OAVaQYrOE6lwM7wH7Y6l4Kws0Lttxxle/76YTHbyP2PlLla+1a mwJQGgJQByEhYcUq6uBIIWl4vMR35E0eYPzS3tP4DEYYbqHIHACW7bTg6ZBtsJErLzQG OP743C74DCKYEt+Z3LOuY14q8hpo/Rg7YACYw/Lh1arGEqFC+vmE3ugW/0yKxXJdktm5 rhJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q7si1551779pgk.456.2019.08.23.02.51.50; Fri, 23 Aug 2019 02:52:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403899AbfHWCxb (ORCPT + 99 others); Thu, 22 Aug 2019 22:53:31 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:56266 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731416AbfHWCxa (ORCPT ); Thu, 22 Aug 2019 22:53:30 -0400 Received: from callcc.thunk.org ([66.31.38.53]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x7N2rI2G031623 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Aug 2019 22:53:19 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 4157C42049E; Thu, 22 Aug 2019 22:53:18 -0400 (EDT) Date: Thu, 22 Aug 2019 22:53:18 -0400 From: "Theodore Y. Ts'o" To: Rakesh Pandit Cc: linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: fix warning inside ext4_convert_unwritten_extents_endio Message-ID: <20190823025318.GB8130@mit.edu> Mail-Followup-To: "Theodore Y. Ts'o" , Rakesh Pandit , linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org References: <20190814095406.GA38531@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814095406.GA38531@localhost.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Aug 14, 2019 at 12:54:08PM +0300, Rakesh Pandit wrote: > Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing > first argument. This was introduced in commit ff95ec22cd7f ("ext4: > add warning to ext4_convert_unwritten_extents_endio") and splitting > extents inside endio would trigger it. > > Signed-off-by: Rakesh Pandit Thanks, applied. - Ted