Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1301621ybl; Fri, 23 Aug 2019 17:17:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqw1wBH6MeqfgqMIWaDBl2A0i1JG74rfS2VqjDW1L+Ls8K+i+BnXCkYKBeJm1KMrf/lhIj1/ X-Received: by 2002:a17:902:142:: with SMTP id 60mr7726886plb.155.1566605871901; Fri, 23 Aug 2019 17:17:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566605871; cv=none; d=google.com; s=arc-20160816; b=C2m96O4WWJ5hkqOpmqb3T48NwthXRrwJETG/sKjwvX9jMJHR+CnGZPgsdW+Fy8ibBd SwZ4KzW2mx/XAVpfqQScGeB3hhzXU+PhtM+E97hxiICA56qBomAaA2dqDP41lPne2O5+ VelcEYdHGticQhvibbxlAFhd2xXz0D33N/ofhxVKl4jp/4eTVvm9zbyGCgAiCiLgxFyE hznljEucDaFlNmHjq3SmMT81LHYDva95YH3Hh8rbsvDPAQLpVu7Du/SrUwvcc0vgN//e o1ODf2uMDExpOxR6xlLw7+05G6A0SJ8HC6cTfcVL1E+ew+T7OYmlBGXN4gyQv/Y1amhC qz7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=aFwMPXyQEJtlseZXUlaUOeKZIjSvv8nJ7h/umrbAxxg=; b=TnFnunXoGW3Fq28kkhcy1SsVWfZT7OCjrGnWM1Se6sN+0mzd2TIWC5sqJzjmJoFbyM j0SCOkg8QUe6vtD5NPCbw/qCS2ES8jhxa9OafHmUegDLm48+E+a9Q/wz3aR82kivY+sx FcJ0fmtz7ONcEiwlTBzx5gR3m0XReAua0PLacmToOXcoDnbgIB/zQOadxaagTWo8CNXV 123Lg1y0JU5yFpYqeKd4fWtzkbyY0VwVDipfpP49HYPjEhJfO8y1e5zTTHwrWPCG7lyk zkwQZ/ET7PrymcAk73DMrXAupnnn4U+wJZDJcZe5Vpil26/6s9cvdtHwyn9kvpnO5g1H 1q1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 130si3154276pgg.18.2019.08.23.17.17.37; Fri, 23 Aug 2019 17:17:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725782AbfHXARe (ORCPT + 99 others); Fri, 23 Aug 2019 20:17:34 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:52326 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725807AbfHXARe (ORCPT ); Fri, 23 Aug 2019 20:17:34 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-111.corp.google.com [104.133.0.111] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x7O0HSAv017564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Aug 2019 20:17:29 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 9B7B042049E; Fri, 23 Aug 2019 20:17:28 -0400 (EDT) Date: Fri, 23 Aug 2019 20:17:28 -0400 From: "Theodore Y. Ts'o" To: Eric Whitney Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: rework reserved cluster accounting when invalidating pages Message-ID: <20190824001728.GA19348@mit.edu> References: <20190817193103.28912-1-enwlinux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190817193103.28912-1-enwlinux@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Aug 17, 2019 at 03:31:03PM -0400, Eric Whitney wrote: > The goal of this patch is to remove two references to the buffer delay > bit in ext4_da_page_release_reservation() as part of a larger effort > to remove all such references from ext4. These two references are > principally used to reduce the reserved block/cluster count when pages > are invalidated as a result of truncating, punching holes, or > collapsing a block range in a file. The entire function is removed > and replaced with code in ext4_es_remove_extent() that reduces the > reserved count as a side effect of removing a block range from delayed > and not unwritten extents in the extent status tree as is done when > truncating, punching holes, or collapsing ranges. > > The code is written to minimize the number of searches descending from > rb tree roots for scalability. > > Signed-off-by: Eric Whitney Thanks, applied. - Ted