Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp5104750ybl; Mon, 26 Aug 2019 22:47:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqzroM+muKSHteESu07D0pb2qw30i7nyC4PchmQaucd56u5GQd4MnRlhiTpHCENtYJKRJN9l X-Received: by 2002:a17:90a:9cf:: with SMTP id 73mr23355109pjo.90.1566884875127; Mon, 26 Aug 2019 22:47:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566884875; cv=none; d=google.com; s=arc-20160816; b=zVzqNYYwNluI2c3OE5Kt1T8rqgUCQfywIkbNUYb+X4beLVhjiKV8voGnhELBag31QP zeDA7yJ4zg/Jq0ggC36VEgsI5pZnE2ZsLi0DvvC5WRXeC8mtgq5uCvnUDTw6QBuiYThA /A+YExYI3Df8oOTxDeLew4mNpyt7zR7A72dFr4q9220r+RG0iSoCLv6U2hQHY20wu5V4 KK6Se0JvB7twv6/DnWU0+0SzeoZoX+sw3F3hqsLIXZw3MSj8BRxt5ka0+bFMEfaJ0AaL IjgOYidHprjjusTdAVVPHwpqUZDQgTY4qm3MXAWj+5va3rQV1gqPA0iWOZrxEucb0E2C biSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:to:subject; bh=B72it5Bbg0/7xySsjB7SOlj9N8jokUcRedJKGirjBHk=; b=MDBSe4oTrI4bDNlxmuDtglnzfd0wMLB+cuQ2BHHoUvXQNxrRvungG6GBIf0FdagaCr FGsDE/PAl/qlcSv6JQlfeH38De++piB+oxLQM22IdG/gw7Dth+CLS/Qnd9osue0HuOmy CX+bz4eXUig7WHkn9k/Io8tMH+va6gmZSwkshVqtXKFIboOpIIHCmnVWdnuK6wJ1Ih/H shVUuyJjVSl8iui20XH82wPO5FR7ebGo0VWBYYwIWU2ESva45CHbmrlNEiWk4qCzeX6q mC5/iDSwg6uZ18IEqzxpo2iRojEnWwUG/FBbPSHFxNKH8CpszAPzd+UPCi00Dge5hK3z rQFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19si12525200pfi.248.2019.08.26.22.47.27; Mon, 26 Aug 2019 22:47:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725874AbfH0Fq5 (ORCPT + 99 others); Tue, 27 Aug 2019 01:46:57 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:38476 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729137AbfH0Fq5 (ORCPT ); Tue, 27 Aug 2019 01:46:57 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9AE8DE6BE64AB22EFF1E; Tue, 27 Aug 2019 13:46:54 +0800 (CST) Received: from [127.0.0.1] (10.74.221.148) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Tue, 27 Aug 2019 13:46:48 +0800 Subject: Re: [PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance To: "Theodore Y. Ts'o" , , , Yang Guo , "Andreas Dilger" References: <1566528454-13725-1-git-send-email-zhangshaokun@hisilicon.com> <20190825032524.GD5163@mit.edu> <20190825172803.GA9505@sol.localdomain> <20190826004744.GA27472@mit.edu> <20190826155728.GE4918@mit.edu> From: Shaokun Zhang Message-ID: <31888086-9ad8-6442-cbf6-c777cbc4947c@hisilicon.com> Date: Tue, 27 Aug 2019 13:46:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20190826155728.GE4918@mit.edu> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.221.148] X-CFilter-Loop: Reflected Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi Theodore, On 2019/8/26 23:57, Theodore Y. Ts'o wrote: > On Mon, Aug 26, 2019 at 04:24:20PM +0800, Shaokun Zhang wrote: >>> The other problem with this patch is that it initializes >>> es_stats_cache_hits and es_stats_cache_miesses too late. They will >>> get used when the journal inode is loaded. This is mostly harmless, >> >> I have checked it again, @es_stats_cache_hits and @es_stats_cache_miesses >> have been initialized before the journal inode is loaded, Maybe I miss >> something else? > > No, sorry, that was my mistake. I misread things when I was looking > over your patch last night. > > Please resubmit your patch once you've fixed things up and tested it. > Sure, will do it soon. > I would recommend that you at least try running your patch using the > kvm-xfstests's smoke test[1] before submitting them. It will save you > and me time. > Ok, thanks your guidance. Shaokun, > [1] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md > > Thanks, > > - Ted > > > . >