Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3039260ybe; Sun, 8 Sep 2019 05:59:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMp5aEOO3eK+NfX2bVndwm3wVdG2YrnXMM2fJ9SAkBAxXQ/kUHQzMlNS4AOjf0WfF6u+md X-Received: by 2002:a50:e885:: with SMTP id f5mr18727864edn.163.1567947566200; Sun, 08 Sep 2019 05:59:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567947566; cv=none; d=google.com; s=arc-20160816; b=BUNZbQij2AFlnnUCEedMtQYThkGlUbNHv5u4dLawvdgrqir+lnVwKI6qcejJfFXhBm ZdsMJth+Cjaohez6UoIge/avUJunLJACsNB+OcygKZ6fl9M5LDk2vyn8fN05M0XiuZFS zsT9DfnFfNbyK117wLrMylVtO1vXUomuX+yaiHv5QxRq2HyxpgXv92lo3j5VE9GTC6CP 2+bY0o2AeMoBn/CjWDzvKLhiCaNN3ClBOFHKacQBWMv8DkjlWMHljkA36x+YfhsD4faq TZmBY+MM5pGAt39kRE1Ju3QUSD+ZYRVyCk97+wxtinYp0Ae43X3NLlSAr9o0gUxlbttx MchA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=uzEIlIBQz79Ce8Yp4c2YignbGVMUWdcpJqcnfVDN8Lg=; b=PCQNZ99oejQ5RXYeJCzK5Fqm4FM+bkFL6wk9UePST6xDI96DfiVFLhYLFJIUjDS8+Y zdSbEkGEq504+AZNs+ImZYdeA/Hy6meSj3KAlkQIFibWkjQYFaeE4dwSWDgOcnyr+h9o cizRNiRuv9UUitPlPAV2BiMAeiAMucvSXvrY8VaEBSOm8IdflOD6jGjcpUgBAk+IXGSS FrRaB7UegFzHJMO7XRpW5ndh1fQUVs2XIG4KZTKzYHsQFTXY8ksmpztlVfQRmrwjPU79 i6HQlO11n+tYp9Me0Qy4I+LjF/4QUY/FIk/nIE0hHB90D+2u6lXllJxizR4NMrvBrOin ZXSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x51si7049114eda.272.2019.09.08.05.59.01; Sun, 08 Sep 2019 05:59:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727096AbfIHIw1 (ORCPT + 99 others); Sun, 8 Sep 2019 04:52:27 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:36715 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727359AbfIHIw1 (ORCPT ); Sun, 8 Sep 2019 04:52:27 -0400 Received: from callcc.thunk.org (110.8.30.213.rev.vodafone.pt [213.30.8.110]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x888qH17025741 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 8 Sep 2019 04:52:19 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 55520420842; Sat, 7 Sep 2019 12:00:04 -0400 (EDT) Date: Sat, 7 Sep 2019 12:00:04 -0400 From: "Theodore Y. Ts'o" To: Xiaoguang Wang Cc: linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: disable mount with both dioread_nolock and nodelalloc Message-ID: <20190907160004.GB23683@mit.edu> References: <20190731130600.7867-1-xiaoguang.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731130600.7867-1-xiaoguang.wang@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jul 31, 2019 at 09:06:00PM +0800, Xiaoguang Wang wrote: > Mount with both dioread_nolock and nodelalloc will result in huge > performance drop, which indeed is an known issue, so before we fix > this issue, currently we disable this behaviour. Below test reproducer > can reveal this performance drop. Is it really worth it to disable this combination? Nothing goes *wrong* per se; it's just slower than we would like. - Ted