Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3997077ybe; Mon, 16 Sep 2019 05:07:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxJqoVzaCOxQTRU2fTyASM6tshjzl80pg30cjVoXWgYLbP1zhGjnhkUGjiUHyfpP6kwAXB X-Received: by 2002:a05:6402:1501:: with SMTP id f1mr7739417edw.76.1568635661696; Mon, 16 Sep 2019 05:07:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568635661; cv=none; d=google.com; s=arc-20160816; b=X8ePHG/8tfgNFRZ85feA8kq/9qR5hzWK5V5mJsYU42+ICrMpZufCL48i+KDsWUmrDV zBrDr+aUWPX6hjjL9tt/f3T/dKsOEz8xC5/jzWmZPgh1VtK4q5/YhHlI5gOI+0IQSVgA hTcZ+YiyMsEl04Yed5xdLYr0ySkv5y3nTKRRe2i20j90UXkmVoPDMhBKFmso9IvNmkg2 NXKyf+ZDLwG5mc/ETEvEkCDBSKwep/wyv/VY/7JpurS+MtA/8qz9JrwvyD0/Yqu9dDvh dxUw8wF5h9AcGDMSU3hA9jLZ7alWgThI18osdzAuEO8/GKSLdBZO30cL/qr9Ncn/etsD X1AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XSL6Bl9hJ55gtSPqYwN0+CzMifMcYDXzcyu9qPjx0g8=; b=rrzenqYJbVC9Fhn3nLj6YfQcyqttiCQjSIzIuXBDj72Gme4an572uOgGCHIsXVYZSo af1dXhc1g9/nqBAuyPCRaLcRRy1xXldJt76Xb9Hra+smpWHmeIx4QhTTh5EutWONOxHh /OZx6ecfnHIW+PXur0eqB1Jz3hPPWhlfvWZt5JoNefb6BpQTClKzgNa6nLI4EeyHGuOQ u5RinrOce+nmqYEnnRQu2ROTe8LOo0W3IR5yE+0PgTNi6LyidlsA2ki/5QnQWJM5heoX In/65EllQb9BE4kJMK8z46dr6bm/MWtCnf/hX3a4oJw7vKGklOE60W5RklWv/PaEqzld N01Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="m4bkG/dJ"; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q18si10681349ejp.226.2019.09.16.05.07.17; Mon, 16 Sep 2019 05:07:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="m4bkG/dJ"; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731844AbfIPMGg (ORCPT + 99 others); Mon, 16 Sep 2019 08:06:36 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:45548 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731744AbfIPMGg (ORCPT ); Mon, 16 Sep 2019 08:06:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XSL6Bl9hJ55gtSPqYwN0+CzMifMcYDXzcyu9qPjx0g8=; b=m4bkG/dJ6IPt2DdgvnxhTcb1W ucMj8d/IESwVkNRT7PJCUMhlz1Z9FILucsSV8elbNd9sN84srFZTcu31FBiGBY5V/h+c1O+7I2HuF Bm51zi9bKarUmyVW6UkwvRDnXV7w28cxYd114bfuZmHO2KFGpvoGeya2ssp6voj94uVOA319qLSMP weo9l6aEQpZ4ez+Cdw7SDICwnPv3VsIYCO4w7+k3RDDxwyhmKyp/FYmFXHhNwP+Q8q8XCZFLv7DD8 3xzPl3vpyOivVq0Gbd1cX/xKhIgp+lrWFzONTMsvfP4OFg/qKNvx2TA1G5T1SR5Q4gXghoYLl02pB 1U47CvDeQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9pm4-0004jl-9q; Mon, 16 Sep 2019 12:06:32 +0000 Date: Mon, 16 Sep 2019 05:06:32 -0700 From: Christoph Hellwig To: Matthew Bobrowski Cc: tytso@mit.edu, jack@suse.cz, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, hch@infradead.org, darrick.wong@oracle.com Subject: Re: [PATCH v3 6/6] ext4: cleanup legacy buffer_head direct IO code Message-ID: <20190916120632.GC4005@infradead.org> References: <1d83ac7f8088837064b90cfb3182a37b46356239.1568282664.git.mbobrowski@mbobrowski.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d83ac7f8088837064b90cfb3182a37b46356239.1568282664.git.mbobrowski@mbobrowski.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Sep 12, 2019 at 09:05:03PM +1000, Matthew Bobrowski wrote: > Remove buffer_head direct IO code that is now redundant as a result of > porting across the read/write paths to use iomap infrastructure. I still think moving the removal of the not required code into the actual patches that make the code obsolete is a better idea. That makes it very clear what is added to remove what kind and amount of old code.