Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 16 Sep 2019 18:46:07 -0700
User-Agent: K-9 Mail for Android
In-Reply-To: <CAHk-=whfPwei+yf9vBgfSuG5HDtiYmt3nOu9Js+vkTYSrMf2ow@mail.gmail.com>
References: <20190916042952.GB23719@1wt.eu> <CAHk-=wg4cONuiN32Tne28Cg2kEx6gsJCoOVroqgPFT7_Kg18Hg@mail.gmail.com> <20190916061252.GA24002@1wt.eu> <CAHk-=wjWSRzTjwN9F5gQcxtPkAgaRHJOOOTUjVakqP-Nzg9BXA@mail.gmail.com> <20190916172117.GB15263@mit.edu> <CAHk-=wgs65hez6ctK7J2k46BdQzvKU5avExPOTTJsZu6iqA-ow@mail.gmail.com> <20190916230217.vmgvsm6o2o4uq5j7@srcf.ucam.org> <CAHk-=whwSt4RqzqM7cA5SAhj+wkORfr1bG=+yydTJPtayQ0JwQ@mail.gmail.com> <20190916231103.bic65ab4ifv7vhio@srcf.ucam.org> <CAHk-=wjwJDznDUsiaXH=UCxFRQxNEpj2tTCa0GvZm2WB4+hJ4A@mail.gmail.com> <20190916232922.GA7880@darwi-home-pc> <CAHk-=wh2PuYtuUVt523j20cTceN+ps8UNJY=uRWQuRaDeDyLQw@mail.gmail.com> <BEF07E89-E36D-480F-AB1E-25C80C9DABE7@srcf.ucam.org> <CAHk-=whfPwei+yf9vBgfSuG5HDtiYmt3nOu9Js+vkTYSrMf2ow@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
To:     Linus Torvalds <torvalds@linux-foundation.org>
CC:     "Ahmed S. Darwish" <darwish.07@gmail.com>,
        "Theodore Y. Ts'o" <tytso@mit.edu>, Willy Tarreau <w@1wt.eu>,
        Vito Caputo <vcaputo@pengaru.com>,
        Lennart Poettering <mzxreary@0pointer.de>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        Jan Kara <jack@suse.cz>, Ray Strode <rstrode@redhat.com>,
        William Jon McCann <mccann@jhu.edu>,
        "Alexander E. Patrakov" <patrakov@gmail.com>,
        zhangjs <zachary@baishancloud.com>, linux-ext4@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>
From:   Matthew Garrett <mjg59@srcf.ucam.org>
Message-ID: <C4F7DC65-50B9-4D70-8E9B-0A6FF5C1070A@srcf.ucam.org>
Subject: Re: Linux 5.3-rc8
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

On 16 September 2019 18:41:36 GMT-07:00, Linus Torvalds <torvalds@linux-fou=
ndation=2Eorg> wrote:
>On Mon, Sep 16, 2019 at 6:24 PM Matthew Garrett <mjg59@srcf=2Eucam=2Eorg>
>wrote:
>>
>> Exactly the scenario where you want getrandom() to block, yes=2E
>
>It *would* block=2E Just not forever=2E

It's already not forever - there's enough running in the background of tha=
t system that it'll unblock eventually=2E=20

>And btw, the whole "generate key at boot when nothing else is going
>on" is already broken, so presumably nobody actually does it=2E

If nothing ever did this, why was getrandom() designed in a way to protect=
 against this situation?=20

>See why I'm saying "hypothetical"? You're doing it again=2E
>
>> >Then you have to ignore the big warning too=2E
>>
>> The big warning that's only printed in dmesg?
>
>Well, the patch actually made getrandom() return en error too, but you
>seem more interested in the hypotheticals than in arguing actualities=2E

If you want to be safe, terminate the process=2E


--=20
Matthew Garrett | mjg59@srcf=2Eucam=2Eorg