Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp1536476ybj; Fri, 20 Sep 2019 12:05:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJ3sAfE0q2Cl/9UQhBttL83ix+L3LkNMWb8dJ7akOjbt7Alkt8enCRMUUIuDwPKQOx/NR4 X-Received: by 2002:a50:f00c:: with SMTP id r12mr23841430edl.274.1569006340451; Fri, 20 Sep 2019 12:05:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569006340; cv=none; d=google.com; s=arc-20160816; b=u6qCKGTRn9EqNi2koKwfRrwYKlDuGUJPfy+jjnabKLJGDN2NDYihN4WuDGis/AHU9o J9OAVphr/EKP5lfGIZuqaw8h0NPE6zYQoUp84+6P7wnUTEo7MYTRLosYZwj1xysnDpy9 V2gVKtwZ1WzVZ/h7IN7WHoLr/7DiKlI3eVwhK6qn2rgFqzUAPllu7Umx8jTmLrFlGFoV pzDehaHcLPM5okf+iIxHfq5+mqrDAQbOsU3Qg0peOhweA80iqS8JG+YBTASAvEd5+BRe eRfqSbkLEztiBy+mv7TJk9nt0A/CNdG0SnFbKdcvszDrG32q24xl2hA9nfKWZuKHW/Yi YwTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=RN3zu2NeiIKJV0auVUKWhllnvElvjAgqNhNsAFZ3BgM=; b=CFT4lyQR5orHpfGPYtpUeb5d6dVs4+MrMLVtioF6y+2cV50MsrqG1lPS3TznhTVUg6 2lGTLDrzl13DvFXNzqlC2DVnYG4Yzazmq6q1s7RV/lQMFK/8eR576GGpP2p0E1c1Dh5j islFzK94dU8bZY2g99RVKUx8ao/ez/4eHvggFj+nvFm6gqVsDvJttxUmKnS29oQTRxc/ VeAxnWIhDm9mr8csI9t2uUqXfCPY0df7pTwMYd6sJMIDHFolepD57hWfr0mjLyqAAMYq apIp1V8jTxLkBLwnrvTdHGD8ckWVUCRkLSKU0zUZrz44jX3B46qbiSbpNPnrEa9Ixlxp WLyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pin0EAM6; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si1947947eda.285.2019.09.20.12.05.04; Fri, 20 Sep 2019 12:05:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pin0EAM6; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437827AbfITJiR (ORCPT + 99 others); Fri, 20 Sep 2019 05:38:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:53960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405989AbfITJiR (ORCPT ); Fri, 20 Sep 2019 05:38:17 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 921C92086A; Fri, 20 Sep 2019 09:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568972296; bh=tGK4is/D5yjSmtKMNJsAOY7JysJV6v3B5d+jHSPQihw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pin0EAM6iDgkBVW67KjzDhHgn5lVksFzTRsfquXbR3bJHYdq/O5aV471P+JzSmcS6 YHKtvlpkzAdl1VYGzcfByN4VuQ4TGD3IU+uGOYlo8hc9sDRuxSD05aPMHw1eu/wEnh h/JzstVetnB6YPglx4zQBqM6UU+z/+zyzbI85BIc= Date: Fri, 20 Sep 2019 10:38:06 +0100 From: Will Deacon To: Qian Cai Cc: akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org, jslaby@suse.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, intel-gfx@lists.freedesktop.org, tytso@mit.edu, jack@suse.com, linux-ext4@vger.kernel.org, tj@kernel.org, mark@fasheh.com, jlbec@evilplan.or, joseph.qi@linux.alibaba.com, ocfs2-devel@oss.oracle.com, davem@davemloft.net, daniel@iogearbox.net, netdev@vger.kernel.org, bpf@vger.kernel.org, duyuyang@gmail.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, alexander.levin@microsoft.com Subject: Re: [PATCH -next] treewide: remove unused argument in lock_release() Message-ID: <20190920093700.7nfaghxdrmubp2do@willie-the-truck> References: <1568909380-32199-1-git-send-email-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1568909380-32199-1-git-send-email-cai@lca.pw> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Sep 19, 2019 at 12:09:40PM -0400, Qian Cai wrote: > Since the commit b4adfe8e05f1 ("locking/lockdep: Remove unused argument > in __lock_release"), @nested is no longer used in lock_release(), so > remove it from all lock_release() calls and friends. > > Signed-off-by: Qian Cai > --- Although this looks fine to me at a first glance, it might be slightly easier to manage if you hit {spin,rwlock,seqcount,mutex,rwsem}_release() first with coccinelle scripts, and then hack lock_release() as a final patch. That way it's easy to regenerate things if needed. Cheers, Will