Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp563082ybp; Wed, 9 Oct 2019 00:09:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqyIx8feVRNMWKe0R5cFGjWbCuNutlma892uiWLymsWPzUs3zgxsspK63XOA1qHhCCOa3TiR X-Received: by 2002:a50:d4d7:: with SMTP id e23mr1595824edj.135.1570604989244; Wed, 09 Oct 2019 00:09:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570604989; cv=none; d=google.com; s=arc-20160816; b=iQ6ueiiyj0t1unD/80zYbzK6zY8Q82h76eO9b3VZzZjSjspRnnFptOfxTre19Wu7KO Hf6brYMS0QNf8semWk9x3QtNkBpFRFP/11wRfB70VL4zhoq6kx/VshrgAaG+YNUARmkY BpQ1ybc3X0YSQlCRo4IybkiTrF+qeB3TQeIuBacGsKsmAWe55tsU5t5rft8S9Dnt1qEn o0FOUtEXy5Q+BmYXBk1kPpIutSwlsReRklwbbAd2mMQNK1SG6ejbn+ulo9A0UKDiwEVZ WT8VT6XimSR6zykDiYhkIMAzuWf+d+442GVrMSByt+3DX5R72lXbwXolqlwlM6qaoKPD YkdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MGvQWs9rgoPYdPU6u7T0lBa25VmxpsDkrkmLedqYBZM=; b=SbtNGHLogeMl1QecDkywioFOJOyxhUDTNCBUEQlmMrPQVj+3kxbY3QHa/Kx5KmYj9h FgjHAdnNPDHmR9iugfHhbA1At9jknGwe3NYukiP8vv/lqWVIQGPKyR51HsCm7W5Tdr7a O8mm6FEioVqzq5WTQIJ2GpjaxYbktv4OysaFHZK83SsPm4y+2/vUfUEkBQNU0IRHaMB9 1BPcU6Hhi0FhhR3vfpbduxUM9zbBRLFxPyY9PM7ttLnvRkodknhhRYfF3hS0wRs2kaWv etA4PUt2B4Itr+4L7xaKQsrHFK0I/I4fuAQscmvMqIHbC9TxbJI4iFKT6L84s1XF1vAD m2Hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=pBe3nj0V; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r16si722682edo.307.2019.10.09.00.09.18; Wed, 09 Oct 2019 00:09:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=pBe3nj0V; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725848AbfJIHHu (ORCPT + 99 others); Wed, 9 Oct 2019 03:07:50 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:51814 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbfJIHHu (ORCPT ); Wed, 9 Oct 2019 03:07:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MGvQWs9rgoPYdPU6u7T0lBa25VmxpsDkrkmLedqYBZM=; b=pBe3nj0V/WHm0xTjsyzrDfHdr Fwxf0Y8tp7TGOeb5lsuIEGSQeuICm2vJMYWW6mbLL7P9MUBQDVj+1Iv9xvEuLeG5YRnK7gQzjwHxi 6DnsxgE33R0bH/vJsZyWSUTdyYpxDPB5AkWaENjMY8mJFT6SuXkOdeu3h7Jzv+6m/xzH35wo410YU Q4kvQZeRWN+u0ErHsd/AuVVP0LeJIaAzWROa0r8FSblngRywv+Ha96Vk5k9Mvy+BCV/2ra8Hwxx65 q7EkVZ0arGkUpPYIgeiCSn7oAicJvDrJEZvflEIQ8VWx+OedvhFuO0E+IzBZ23pSsT4L3LFBkZHMq zd6LMCZvQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iI64X-0000RW-3t; Wed, 09 Oct 2019 07:07:45 +0000 Date: Wed, 9 Oct 2019 00:07:45 -0700 From: Christoph Hellwig To: Ritesh Harjani Cc: Matthew Bobrowski , tytso@mit.edu, jack@suse.cz, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v4 1/8] ext4: move out iomap field population into separate helper Message-ID: <20191009070745.GA32281@infradead.org> References: <8b4499e47bea3841194850e1b3eeb924d87e69a5.1570100361.git.mbobrowski@mbobrowski.org> <20191009060255.8055742049@d06av24.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009060255.8055742049@d06av24.portsmouth.uk.ibm.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Oct 09, 2019 at 11:32:54AM +0530, Ritesh Harjani wrote: > We can also get rid of "first_block" argument here. That would just duplicate filling it out in all callers, so why?