Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp746778ybp; Wed, 9 Oct 2019 03:40:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOXG76OyPT3rGy4N5Fai1ldSj1ZO9pxv+xRlSbC/+dxDzL0v7d/OpQgO6oE9P9e9uhq5+h X-Received: by 2002:aa7:d2cf:: with SMTP id k15mr1104976edr.208.1570617620496; Wed, 09 Oct 2019 03:40:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570617620; cv=none; d=google.com; s=arc-20160816; b=eeSBWEI2x6ZJbvR+9IGORuHfO03h34nk6FvmO8HRvy+qDl6ZWtJk8Z+HruJMSp9EMO FTZJy8zE6OcpDfFqJt2DVKTv36U6M8NJczAZUtlBSmXuaehvPv+KQ9kgbYI+b+DVOuyn E5u0ajlTBjf6vZADWAtSFv4+T81PhKlb9rv6f6kFQZ/wfy50gsqsjpCOQCmURdUFbjYZ NhHxsldfCTY6c74AAjuKdVxd24aIXt3MVnCNK+VkIwGzW1AixIlTEKn2k7Cc5IDUYIU6 8k5FdUAiwalk+zWyO4w98MHb5AxTVBoU806ypOkioOJ59lUmIrWGNvRo1HJ4UI0cOxkq Ykdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=l2iX8XelpbvqMiP2lxIuWsuTbSoIGNGBULpyGQfwuWo=; b=nHVXkk0yh7desRnVaohgKOkw8pALseKkzq7QK2xnQ7hVyiIdhz+urNww2TUDP6fYwW goqErxXECzYLmWW6VOeFXRTQ2vdmOOQtzknGVd3MyTxtY8sNu1bu50QhJ4TvBhN8zTxJ nI71+sNuj0YtgaQDIavM6RExFytSgdwaRoXr+fgOC1GjMXSn+MlE90z4/LJjABKjMEtS xMOJpH53psDVm2QCIgPfU68jEVkugApXUN2DBwF/PNIb30HhRyYvTa7vlqxqKPw4ptiN UBOI4DyNpT78DNW1uM8ub55kYDEAEZvBERu805ts3YvIEepb71/8Tl9WI9muBrEP5FRV 3cQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mbobrowski-org.20150623.gappssmtp.com header.s=20150623 header.b=iPMU4rrM; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6si928930edr.443.2019.10.09.03.39.52; Wed, 09 Oct 2019 03:40:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@mbobrowski-org.20150623.gappssmtp.com header.s=20150623 header.b=iPMU4rrM; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727228AbfJIKjq (ORCPT + 99 others); Wed, 9 Oct 2019 06:39:46 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36992 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726579AbfJIKjq (ORCPT ); Wed, 9 Oct 2019 06:39:46 -0400 Received: by mail-pl1-f195.google.com with SMTP id u20so865066plq.4 for ; Wed, 09 Oct 2019 03:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l2iX8XelpbvqMiP2lxIuWsuTbSoIGNGBULpyGQfwuWo=; b=iPMU4rrMThH8TMZDqFkrtFr5BUdjzbx5x2PeHuZRuzNT6m0bdgl0SDlSupx2+4+xNk 4ow0YfJ9tr18QSD9/HxWgfYC4CdtA/pslKyyN1QeRwKDXHivhHsS0caPDA+FX7Z6CtHA pXm73FEZu9syAzidEpVHMTcszOcbPHZLpEAF1yFhwTuuo1rH8oU+HK73dxzi5gRElwv7 CRI/i1QNWYL0brtKOQD/61azOc3xxPeuOMLM/UXCtevIjI4Z6cpmg59igWKX8AQCMSPO XSEPk9nl38UbV6wJU0011rdh3+ANRNTEusVmuG3nHVWSyhu6/wkv2Q//UvXxfAF7eu4R 7Zvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l2iX8XelpbvqMiP2lxIuWsuTbSoIGNGBULpyGQfwuWo=; b=cuMw/440JcDvclLcAMaEmHXTsTRTn5iOvqwKIngGzb7CeZwEqzL1kGk4CkhOuJksn/ fi6C96UL3lWARF5A25HMCJUioeUqay37pWQEem1HlZ2jQhvytbeFC/TJ3l80ws8TQC9O vtGhh4n1dmN70h2m1xKOUjVhUEnfEGMmGFKJcxJ9FG0ArUUzdV7KlrJaV9oGkCbW2JA8 R3zS/K4WI6rCO/wjqQdgMebg6OPWVPCC39EjnkDGg3X7ZTTYtZaGHjl6DGRma+cQmAq6 2tFLwEVeaEljfoUIwU8qbapvs+3RZcXQBXp8S2reqcxT72/f8wAVWzsbvES6ZzTkdiDT +uVQ== X-Gm-Message-State: APjAAAU9AR0n+Unh0ZHg99K6pSOjE1LHuyK9iiS0ELdcADE0OY8qxMjs 5nz68ZjA0t33n0FxhyIx6hVT X-Received: by 2002:a17:902:a717:: with SMTP id w23mr2484798plq.27.1570617584267; Wed, 09 Oct 2019 03:39:44 -0700 (PDT) Received: from poseidon.bobrowski.net ([114.78.226.167]) by smtp.gmail.com with ESMTPSA id w14sm4734445pge.56.2019.10.09.03.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 03:39:43 -0700 (PDT) Date: Wed, 9 Oct 2019 21:39:37 +1100 From: Matthew Bobrowski To: Ritesh Harjani Cc: tytso@mit.edu, jack@suse.cz, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v4 6/8] ext4: move inode extension checks out from ext4_iomap_alloc() Message-ID: <20191009103935.GC14749@poseidon.bobrowski.net> References: <20191009063023.E332942047@d06av24.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009063023.E332942047@d06av24.portsmouth.uk.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Oct 09, 2019 at 12:00:22PM +0530, Ritesh Harjani wrote: > On 10/3/19 5:04 PM, Matthew Bobrowski wrote: > This looks good. Should solve our previous lengthy discussion > about orphan handling :) Yeah, although I'm still not the biggest fan of this approach. > You may add: > Reviewed-by: Ritesh Harjani Thanks Ritesh! ----