Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp749036ybp; Wed, 9 Oct 2019 03:43:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqyuSLMQVGAPtKo2J2xEqvtoxeOikW/qwuG1BY66AxNEDMVRuUqZQuRbWwvfF8/AScIgVx2p X-Received: by 2002:a05:6402:14d6:: with SMTP id f22mr2333019edx.148.1570617784737; Wed, 09 Oct 2019 03:43:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570617784; cv=none; d=google.com; s=arc-20160816; b=klXul0jmCRjkOP8tZnv5jZbWfMgk7trNgVRaFH2r6JTIvOrxhqUMpuhEYg76RmmcmD VTScxBjcUuQJPjPFDKucL7DHasMAtybwc5W52UzI1vDZss5Wf9N4JNOz49f15wRdCbBu fB6VeT0ui+YiTdi1Tvdyghrr8AGJCNBvN4Phvq8fDqCSJbZLszlwZCmZNtXFtnsr/GLu q8et4hvfLVOMYrwrunhhcHGB+Mvw2YgzkYWb7hImE33xukkTV8Sc8n38LR5jQ0YA0fEN TOA/M6lqmeyv6CRIeDaCHypqPlG32w/TQTpkhA35Rxmct/ecyD+QchkixFYU9CVVc5X+ MoPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Bm58YBswdlISkDr/Ri9rK9T+YxLaZyKmJp4DGvcJTBg=; b=d/+p6tQ9zaHLd48sWqFqOiDqeIECYbDjUmkYHZaNz1SQ3z7VuX7Sr8jUmPUQjfbFJw hTfOQx3lvBXQYHr5XgJ/o+5WFnDAf/0GT+jofrhLDC2uwn79cW82FxXxbobiEBGgxdzb ma5lWZmPND4iWXjq7PE6nKu2S1qz95V7FlcEFmkdH+eZ3mt3ktgQzjlEdR38TyFviDLg 7Lu/V/RxXNycQRuaqca8AHUMS0Xikp29Pab+9WBMshXHr3TuMjWr1B0hK7CpkbkTBYCf kS3JTKuvb4UgP87xuYyrzUITtQXbsNmc4Z4kpQgcJqszp2bwhgs0xtHvEYaa3wWPDPZq JK8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mbobrowski-org.20150623.gappssmtp.com header.s=20150623 header.b=I8aIhyJ8; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e6si924836ejb.348.2019.10.09.03.42.40; Wed, 09 Oct 2019 03:43:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@mbobrowski-org.20150623.gappssmtp.com header.s=20150623 header.b=I8aIhyJ8; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729784AbfJIKmb (ORCPT + 99 others); Wed, 9 Oct 2019 06:42:31 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:41904 "EHLO mail-pl1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729566AbfJIKmb (ORCPT ); Wed, 9 Oct 2019 06:42:31 -0400 Received: by mail-pl1-f181.google.com with SMTP id t10so859046plr.8 for ; Wed, 09 Oct 2019 03:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Bm58YBswdlISkDr/Ri9rK9T+YxLaZyKmJp4DGvcJTBg=; b=I8aIhyJ8I7eXY+MUGOunHtMn6yXr1flIzb64UdLjR6f4S4S4HW8P+ydbg8Mb5x771M gfFVAxGILf6ALC5vbppKVpqPeMUBIYR/HzP4TRvu7eU2b/3QdGcpB3Zxdg5pmyUHSS40 pG1/gNBxuLT7YP6uFqNm6lJ6oSB2mO/t8svE5FpbAxxxYqkFXSb6GVI96UPQ0B2cKLZX wjiGJ5q4MCR5Ad6C14cQA1Bn9quHwGmphku24TcrlJLffYjbrwqhk5R0Jj5SAqQnXh7C gOA/Yu39oCaUbjKNNjevJxzyhs21oJ8a28wh98pu49VvKNANvtGMG4aEv1+52Lvywoqd Janw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Bm58YBswdlISkDr/Ri9rK9T+YxLaZyKmJp4DGvcJTBg=; b=OaQGE8jldMomNwCtLaC1bchScMufyJMeAbwmXXgLcOPFhY+E5dyHHVs5JfYMin+0Uc pIv4KSwyC5iIdEcKeAu5RoyXo+edBMvmpU6a4bygBNerAiRh8gHzmQHWppuoL/1wTQgd IArdMqBKuRYXpvPdX+EqNKGBdsS3ylNJKXDQ+4YQYaW/YEAz65ZkA4BwytOa6BboBvuf 8d+Lxf5eOFnrbyhMoGja6HZJtUJS1+s7LX4eWtzi/5dSO5eRRHtTORGuW68HSYEjF/NN fbEjDgjv67TL9PENUivBQ+Q9f23dMlTU0RZhQlMAdbB8VqjYM0lvNSnKVbNXug06GZio F3BA== X-Gm-Message-State: APjAAAUmGXLfFu1crub7zrV5WDOdPzVF1+Tdxe/QgQZocujHWEhIIG6m gGBcxN1PIUvzqBsUpUR8PQ0U X-Received: by 2002:a17:902:930b:: with SMTP id bc11mr2488108plb.284.1570617748885; Wed, 09 Oct 2019 03:42:28 -0700 (PDT) Received: from poseidon.bobrowski.net ([114.78.226.167]) by smtp.gmail.com with ESMTPSA id f128sm1955760pfg.143.2019.10.09.03.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 03:42:28 -0700 (PDT) Date: Wed, 9 Oct 2019 21:42:22 +1100 From: Matthew Bobrowski To: Jan Kara Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v4 7/8] ext4: reorder map.m_flags checks in ext4_set_iomap() Message-ID: <20191009104220.GD14749@poseidon.bobrowski.net> References: <3551610e53aa1984210a4de04ad6e1a89f5bf0a3.1570100361.git.mbobrowski@mbobrowski.org> <20191008113012.GJ5078@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191008113012.GJ5078@quack2.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Oct 08, 2019 at 01:30:12PM +0200, Jan Kara wrote: > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara Thanks Jan! > Just those 72 columns limited comment lines... ;) *nod* - will be fixed! ----