Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chengguang Xu <cgxu519@mykernel.net>
To:     tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.com
Cc:     linux-ext4@vger.kernel.org, Chengguang Xu <cgxu519@mykernel.net>
Message-ID: <20191015102327.5333-1-cgxu519@mykernel.net>
Subject: [PATCH v2] ext4: choose hardlimit when softlimit is larger than  hardlimit in ext4_statfs_project()
Date:   Tue, 15 Oct 2019 18:23:27 +0800
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

Setting softlimit larger than hardlimit seems meaningless
for disk quota but currently it is allowed. In this case,
there may be a bit of comfusion for users when they run
df comamnd to directory which has project quota.

For example, we set 20M softlimit and 10M hardlimit of
block usage limit for project quota of test_dir(project id 123).

[root@hades mnt_ext4]# repquota -P -a
*** Report for project quotas on device /dev/loop0
Block grace time: 7days; Inode grace time: 7days
                        Block limits                File limits
Project         used    soft    hard  grace    used  soft  hard  grace
----------------------------------------------------------------------
 0        --      13       0       0              2     0     0
 123      --   10237   20480   10240              5   200   100

The result of df command as below:

[root@hades mnt_ext4]# df -h test_dir
Filesystem      Size  Used Avail Use% Mounted on
/dev/loop0       20M   10M   10M  50% /home/cgxu/test/mnt_ext4

Even though it looks like there is another 10M free space to use,
if we write new data to diretory test_dir(inherit project id),
the write will fail with errno(-EDQUOT).

After this patch, the df result looks like below.

[root@hades mnt_ext4]# df -h test_dir
Filesystem      Size  Used Avail Use% Mounted on
/dev/loop0       10M   10M  3.0K 100% /home/cgxu/test/mnt_ext4

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
- Fix a bug in the limit setting logic.

 fs/ext4/super.c | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index dd654e53ba3d..f24e175ae5e0 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5546,9 +5546,15 @@ static int ext4_statfs_project(struct super_block *s=
b,
 =09=09return PTR_ERR(dquot);
 =09spin_lock(&dquot->dq_dqb_lock);
=20
-=09limit =3D (dquot->dq_dqb.dqb_bsoftlimit ?
-=09=09 dquot->dq_dqb.dqb_bsoftlimit :
-=09=09 dquot->dq_dqb.dqb_bhardlimit) >> sb->s_blocksize_bits;
+=09limit =3D 0;
+=09if (dquot->dq_dqb.dqb_bsoftlimit &&
+=09=09(!limit || dquot->dq_dqb.dqb_bsoftlimit < limit))
+=09=09limit =3D dquot->dq_dqb.dqb_bsoftlimit;
+=09if (dquot->dq_dqb.dqb_bhardlimit &&
+=09=09(!limit || dquot->dq_dqb.dqb_bhardlimit < limit))
+=09=09limit =3D dquot->dq_dqb.dqb_bhardlimit;
+=09limit >>=3D sb->s_blocksize_bits;
+
 =09if (limit && buf->f_blocks > limit) {
 =09=09curblock =3D (dquot->dq_dqb.dqb_curspace +
 =09=09=09    dquot->dq_dqb.dqb_rsvspace) >> sb->s_blocksize_bits;
@@ -5558,9 +5564,14 @@ static int ext4_statfs_project(struct super_block *s=
b,
 =09=09=09 (buf->f_blocks - curblock) : 0;
 =09}
=20
-=09limit =3D dquot->dq_dqb.dqb_isoftlimit ?
-=09=09dquot->dq_dqb.dqb_isoftlimit :
-=09=09dquot->dq_dqb.dqb_ihardlimit;
+=09limit =3D 0;
+=09if (dquot->dq_dqb.dqb_isoftlimit &&
+=09=09(!limit || dquot->dq_dqb.dqb_isoftlimit < limit))
+=09=09limit =3D dquot->dq_dqb.dqb_isoftlimit;
+=09if (dquot->dq_dqb.dqb_ihardlimit &&
+=09=09(!limit || dquot->dq_dqb.dqb_ihardlimit < limit))
+=09=09limit =3D dquot->dq_dqb.dqb_ihardlimit;
+
 =09if (limit && buf->f_files > limit) {
 =09=09buf->f_files =3D limit;
 =09=09buf->f_ffree =3D
--=20
2.20.1