Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp7204115ybp; Wed, 16 Oct 2019 05:26:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUYNi0ZcnFLe5PzEZq0U8lTjBPXeUfdLA1RNrnJALnE5xAInNtyUwxe7RD5ofGl8yuLHPg X-Received: by 2002:a17:906:9487:: with SMTP id t7mr39333534ejx.231.1571228805906; Wed, 16 Oct 2019 05:26:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571228805; cv=none; d=google.com; s=arc-20160816; b=ew4EvvX1MUgqSFOe+Px3x0h9TzwkpEyA+Lqmhga5UOLePO1aA7cELfHlQHjPXn9nDK 8T7zfFnKrdrn8JvotnbYQclyIWTe+K/y8Vu+/PCDxjjJro5ts8CAeKlzDQSERuk9KbMe wgsjWAYZBvu5JIKeSBQSARsR0xlNZB4nBsRf33/S+AtInlPpc5aeHty5PVgRwQsPtQK/ 79+yjSM+aQhLsqG3XNesbYWSzVV37ZF2R9NPaF3cmcWOR7ipNWHZR0qn14EIhducmXFE j7w86m8VShfBsIqthInf+7SDERj0RW5F/ZVlGpfo+OtJlwMCOfQNvUNUnVqaQFAx5NFT RC/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:date:subject:cc:to:from; bh=eAVtEtdQRz4jePHaLRtqTPU70PkuHj+2fNJPC89q6iA=; b=qTSum+QeRjCIqg91FckcFhBfkBN/mCOREY7hhxnxOdd4XBPSCVCnYqheAf3cW8GMpJ v59VAbVE+0+mpSGux5OVEYRs4L87cyGjzIQ+SwpJ+0R2QfYoBarMl/gvHl3egIYJJ7C/ C4EbvhIyyK4cfN9TiLvbu/c52OSLXUvS7xqfSRXKo4wA61SvXY04l3rzGUEo1GdUoqb9 LADI7/ZCongPQL08ULHYcQThmFROygnFE2VjkbIX8HJlMbeYNpPoV2cMKn1nzMbHsFaN u4JfArb5oryWtrEe4/0Bq2C1tRJ+bwsjMkWUOFg/q6UfZ3DyghvGoiZSy64HH/y8gIp4 8NVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g25si15048466ejr.409.2019.10.16.05.26.15; Wed, 16 Oct 2019 05:26:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725970AbfJPHh0 (ORCPT + 99 others); Wed, 16 Oct 2019 03:37:26 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:2578 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730523AbfJPHhZ (ORCPT ); Wed, 16 Oct 2019 03:37:25 -0400 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x9G7b0ei013800 for ; Wed, 16 Oct 2019 03:37:24 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2vng3u1a8j-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 Oct 2019 03:37:23 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 Oct 2019 08:37:20 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 16 Oct 2019 08:37:17 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x9G7bGjx42926300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Oct 2019 07:37:16 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 12729AE04D; Wed, 16 Oct 2019 07:37:16 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 80811AE05D; Wed, 16 Oct 2019 07:37:14 +0000 (GMT) Received: from dhcp-9-199-158-105.in.ibm.com (unknown [9.199.158.105]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 16 Oct 2019 07:37:14 +0000 (GMT) From: Ritesh Harjani To: tytso@mit.edu, jack@suse.cz, linux-ext4@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, mbobrowski@mbobrowski.org, riteshh@linux.ibm.com Subject: [RFC 0/5] Ext4: Add support for blocksize < pagesize for dioread_nolock Date: Wed, 16 Oct 2019 13:07:06 +0530 X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19101607-0012-0000-0000-000003587C9A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19101607-0013-0000-0000-0000219394D2 Message-Id: <20191016073711.4141-1-riteshh@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-16_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=549 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910160071 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org This patch series adds the support for blocksize < pagesize for dioread_nolock feature. Since in case of blocksize < pagesize, we can have multiple small buffers of page as unwritten extents, we need to maintain a vector of these unwritten extents which needs the conversion after the IO is complete. Thus, we maintain a list of tuple pair (io_end_vec) for this & traverse this list to do the unwritten to written conversion. Appreciate any reviews/comments on this patches. Tests completed =============== All (which also passes in default config) "quick" group xfstests are passing. Tested xfstests with below configurations. dioread_nolock with blocksize < pagesize dioread_nolock with blocksize == pagesize without dioread_nolock with blocksize < pagesize without dioread_nolock with blocksize == pagesize ltp/fsx test with multiple iterations of 1 million ops did not show any error. About patches ============= Patch 1 - 3: These are some cleanup and refactoring patches. Patch 4: This patch adds the required support. Patch 5: This patch removes the checks which was not allowing to mount with dioread_nolock when blocksize != pagesize was true. _Patches can be cleanly applied on today's linus tree master branch_ Ritesh Harjani (5): ext4: keep uniform naming convention for io & io_end variables ext4: Add API to bring in support for unwritten io_end_vec conversion ext4: Refactor mpage_map_and_submit_buffers function ext4: Add support for blocksize < pagesize in dioread_nolock ext4: Enable blocksize < pagesize for dioread_nolock fs/ext4/ext4.h | 13 ++++- fs/ext4/extents.c | 49 ++++++++++++----- fs/ext4/inode.c | 136 ++++++++++++++++++++++++++++++---------------- fs/ext4/page-io.c | 110 ++++++++++++++++++++++++------------- fs/ext4/super.c | 10 ---- 5 files changed, 208 insertions(+), 110 deletions(-) -- 2.21.0