Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC 1/2] ext4: Move ext4 bmap to use iomap infrastructure.
To:     Jan Kara <jack@suse.cz>
Cc:     linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
        tytso@mit.edu, mbobrowski@mbobrowski.org,
        linux-fsdevel@vger.kernel.org
References: <20190820130634.25954-1-riteshh@linux.ibm.com>
 <20190820130634.25954-2-riteshh@linux.ibm.com>
 <20191016083108.GA30337@quack2.suse.cz>
From:   Ritesh Harjani <riteshh@linux.ibm.com>
Date:   Wed, 16 Oct 2019 18:05:07 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20191016083108.GA30337@quack2.suse.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <20191016123508.5E80DA405C@b06wcsmtp001.portsmouth.uk.ibm.com>
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk


On 10/16/19 2:01 PM, Jan Kara wrote:
> On Tue 20-08-19 18:36:33, Ritesh Harjani wrote:
>> ext4_iomap_begin is already implemented which provides
>> ext4_map_blocks, so just move the API from
>> generic_block_bmap to iomap_bmap for iomap conversion.
>>
>> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
> 
> This seems to have fallen through the cracks. The patch looks OK, feel free
> to add:

Np. Thanks for the review :)


> 
> Reviewed-by: Jan Kara <jack@suse.cz>
> 	
> 								Honza
> 
>> ---
>>   fs/ext4/inode.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
>> index 420fe3deed39..d6a34214e9df 100644
>> --- a/fs/ext4/inode.c
>> +++ b/fs/ext4/inode.c
>> @@ -3355,7 +3355,7 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block)
>>   			return 0;
>>   	}
>>   
>> -	return generic_block_bmap(mapping, block, ext4_get_block);
>> +	return iomap_bmap(mapping, block, &ext4_iomap_ops);
>>   }
>>   
>>   static int ext4_readpage(struct file *file, struct page *page)
>> -- 
>> 2.21.0
>>