Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp7502116ybp; Wed, 16 Oct 2019 09:34:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqw0SAizZ1WMWY7x2W8ktuLktHlJYBKghYgAOQR1MgmOoNsj67LEYaF8LyJ9BAGQI3ewEpQk X-Received: by 2002:a17:906:3053:: with SMTP id d19mr41703086ejd.109.1571243677567; Wed, 16 Oct 2019 09:34:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571243677; cv=none; d=google.com; s=arc-20160816; b=DpW+HcsoAOMnVTnozwbnJSmd6roszedSCuOdDrX7rHSpV2NR59ZxSK3G7HHKf14YFa 7BOpcFcOhh0AN9s8Z/oMsezk7yIqjH57uXF0YhNwayamYWJFZ9jOpT43ZW1zzxRY26yZ xbGMDCqWOAhQH+6/36PY8tTW/IeQeXhiondROcV2bGHLimtTdQV1iCSLUn0N2E+PBp1o LvTzcfE2FHsDU3dMcV1Jj+5ZqcXbqaj/cQu7q4Wt0OWpZeAHo20JIhCWr8eM7xW/Z+IL Tohv4WGQoQXbFHtSdrIN9peJkMgMuQJM27VQRs1qUTeEkHCAZ0cytdrSaYbYTxuxLbrL F+RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=80ImiH1uWOxI2PLy0Gp1Efg6BfNAUXSTT412nAfLd8Q=; b=DygL/Ibp1/g7FHXZ1/trZZVdM7yfWfnbnBn69o8PMoVK0Yus1NaZsP7PMkBdglbo+m m1U9e7L22gX2yYsMRcBfwr7sZa3950Sw04L3XVcq1trEjQVfekKVvuzrfPE6eMvkZ1R+ NBdEPgoiNsKxzHhj39tRnX2xwJi5Sz1oPdZyB41m5SLLEW/9jKTKSn1K/P435siZAa2r plYYBxipZg9Mg080CLW/g1jyywDuyy/XTXsFAPmWg3h0rlvnMtVDqwIaXcqf+fAzLFnD GID7r0s/mS5TH8iBF6PGkebZsr7N0G5kW04gmeYdCcGJB1wliPY04AoTDZNWO9UvVcwP Y94g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q28si16138100eda.322.2019.10.16.09.34.10; Wed, 16 Oct 2019 09:34:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404849AbfJPOzL (ORCPT + 99 others); Wed, 16 Oct 2019 10:55:11 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:34631 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2404825AbfJPOzL (ORCPT ); Wed, 16 Oct 2019 10:55:11 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-98.corp.google.com [104.133.0.98] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x9GEswGM010588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Oct 2019 10:54:59 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 7064D420458; Wed, 16 Oct 2019 10:54:58 -0400 (EDT) Date: Wed, 16 Oct 2019 10:54:58 -0400 From: "Theodore Y. Ts'o" To: Iurii Zaikin Cc: linux-kselftest@vger.kernel.org, linux-ext4@vger.kernel.org, skhan@linuxfoundation.org, adilger.kernel@dilger.ca, Tim.Bird@sony.com, kunit-dev@googlegroups.com, brendanhiggins@google.com Subject: Re: [PATCH linux-kselftest/test v3] ext4: add kunit test for decoding extended timestamps Message-ID: <20191016145458.GA11103@mit.edu> References: <20191010235030.143567-1-yzaikin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010235030.143567-1-yzaikin@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Oct 10, 2019 at 04:50:30PM -0700, Iurii Zaikin wrote: > KUnit tests for decoding extended 64 bit timestamps > that verify the seconds part of [a/c/m] > timestamps in ext4 inode structs are decoded correctly. > KUnit tests, which run on boot and output > the results to the debug log in TAP format (http://testanything.org/). > are only useful for kernel devs running KUnit test harness. Not for > inclusion into a production build. > Test data is derive from the table under > Documentation/filesystems/ext4/inodes.rst Inode Timestamps. > > Signed-off-by: Iurii Zaikin This looks good. Thanks, Iurii! Reviewed-by: Theodore Ts'o - Ted