Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1024564ybp; Thu, 17 Oct 2019 07:02:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3ALucLpFDnOqCleHNXX9h/G4rGW04k5FaA213cjzZqFOkfDpZrkRiHwOBkwn9rdKv4LUU X-Received: by 2002:a17:907:36e:: with SMTP id rs14mr3653869ejb.280.1571320944891; Thu, 17 Oct 2019 07:02:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571320944; cv=none; d=google.com; s=arc-20160816; b=VTblsbN40AUb/4I3J8S3Uyeprl+FWDp7DTeoCIXdfiFIhDx1ZxsI050IQ1HWCdT0rE r+4RD0pZwTyd3byV8OQQKh4mrZ6SJ9/tHmVgRVNu6PtKcxk87F7Zn2ef1IqsrctU32yy lKj4N3UOnRUU80ACx6Vryi3HngqtgzsNySZJyfX6FD11o+7THTp8en+I6Kl9lc1ed3Rk n72lV/YAZHJhTVYpQg59xMSJqh4ynkly3p2exsXQiJnuJX1+t+xON/mXa5Vp6QfZ/Q1U V25r04YAl2VnUBPVLvmgS1dPry2/STnWVl+22ynhONjokFHoFIf+82AVKhHFDqajpSsT oogg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JAxq/WJeBoR0xMDaZ8ZbppkOlnjn80tjwBYmWKfmplU=; b=E91dvtlJ/wiy/J+A8jMAgF/YoHxnNdeIC4UK4kDw2h/lbT1pEGr1Dc8VuUdncXj7H4 Z5udAkD0MFydcAYpLdYYIkzJhLLkqpeP8iLVuUi1fakqitLILfSeER0n6opcbgKP+WHu 98aW2VbGEEFHClkFszGdI51Eczbbd42IfHS164Dnw1MsLDAeVA9DV6E5ubhJSyzrt6AL Hgj30pX4TY7Um1ZjRuHccezq0MEVVSTHL32zkZlvpPBiYNY7P59eM8853gr6MHr3f17F OKLGeS0UmVMhtnl/7cJeQNzuZirTcLVG4yikyuAb88F95EsrUvbb+ABYCSPTk29uCN6R qE/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=eyH4aa16; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6si1612465edm.316.2019.10.17.07.01.54; Thu, 17 Oct 2019 07:02:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=eyH4aa16; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388397AbfJPVRv (ORCPT + 99 others); Wed, 16 Oct 2019 17:17:51 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:36812 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388118AbfJPVRv (ORCPT ); Wed, 16 Oct 2019 17:17:51 -0400 Received: by mail-pf1-f194.google.com with SMTP id y22so187382pfr.3 for ; Wed, 16 Oct 2019 14:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JAxq/WJeBoR0xMDaZ8ZbppkOlnjn80tjwBYmWKfmplU=; b=eyH4aa164I+OzfTDTsPKbu6607+lcySeMot2a7BPxRlhclDaFhCxtIH+ysArH/nmBI uliHilHLE6Ngf5x6Ql7n16TztzJXBjGU8+DTbLx2n7QVMBLMF75GGpxJzwUROTm5cJQJ MF4wMf6s7FyWMTLiXLU8quTydRd057AM6TJGevyDRgZ8Tq2R46Rb7xCjMG6EWo/qqbfw cBxGQIOZ0EakMOp3NIxvOVNj1eblV/wKukqxUe+WqJ+W8Gk8EzMcT3PWsv+XwOm4s26g eBevADqdbHyeG2kkYb9dOohYzBAqUkQQpiRKzdKILAJtK60hySl3K9+/JJzq1KAmR+rx 5VWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JAxq/WJeBoR0xMDaZ8ZbppkOlnjn80tjwBYmWKfmplU=; b=BIk/8K5pb3Xz8qibJ50alzIwrOvcWRKZTrruILxG/vB00VdwFTStBJ8nPOCfxXR26d 6fAxsrDoqCpAgb8mrRtF+5njCg6TvV9wgfqCNhpxU2LS8MqXuVMffhTs4b+4NpBklsBa qUrr9y1g0lX++T9kDx0A9Y+pXpfVyziuNTXJDlDVnoJqoDtbbQduhFMf66M2fvclN+Ue uT1mIgfBDtLRyVUpGC5/oFbkIMcobUnYJBpwcozg+2gaxfsFG9m9hOb+UCJy3XTNh+YK sF/JCyHvkx3GDUt39lFlJXHw2XBviiZEerV6p3+Y1a6bXNiw2g6/kTenaghSnN/BlMQi tsDw== X-Gm-Message-State: APjAAAVIwFnyz+usoIuPwR3zCv37N8oU01mAy4DE9g2tntNO1v9mTkP6 /NanU9OJsTPFqrIcmIKaFA/mhQ== X-Received: by 2002:aa7:838f:: with SMTP id u15mr28420131pfm.74.1571260670353; Wed, 16 Oct 2019 14:17:50 -0700 (PDT) Received: from google.com ([2620:15c:2cb:1:e90c:8e54:c2b4:29e7]) by smtp.gmail.com with ESMTPSA id g4sm10074pfo.33.2019.10.16.14.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 14:17:49 -0700 (PDT) Date: Wed, 16 Oct 2019 14:17:45 -0700 From: Brendan Higgins To: Iurii Zaikin Cc: linux-kselftest@vger.kernel.org, linux-ext4@vger.kernel.org, skhan@linuxfoundation.org, tytso@mit.edu, adilger.kernel@dilger.ca, Tim.Bird@sony.com, kunit-dev@googlegroups.com Subject: Re: [PATCH linux-kselftest/test v5] ext4: add kunit test for decoding extended timestamps Message-ID: <20191016211745.GA66058@google.com> References: <20191016205820.164985-1-yzaikin@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191016205820.164985-1-yzaikin@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Oct 16, 2019 at 01:58:20PM -0700, Iurii Zaikin wrote: > KUnit tests for decoding extended 64 bit timestamps > that verify the seconds part of [a/c/m] > timestamps in ext4 inode structs are decoded correctly. > KUnit tests, which run on boot and output > the results to the debug log in TAP format (http://testanything.org/). > are only useful for kernel devs running KUnit test harness. Not for > inclusion into a production build. > Test data is derived from the table under > Documentation/filesystems/ext4/inodes.rst Inode Timestamps. > > Signed-off-by: Iurii Zaikin You got Reviewed-bys from both Ted and myself. Unless you make *substantial* changes you should generally include all Reviewed-bys, Tested-bys, Acked-bys, etc in all future revisions. Cheers!