Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 22 Oct 2019 13:36:18 +0800
From:   Chengguang Xu <cgxu519@mykernel.net>
Reply-To: cgxu519@mykernel.net
To:     "Jan Kara" <jack@suse.cz>
Cc:     "jack" <jack@suse.com>, "linux-ext4" <linux-ext4@vger.kernel.org>
Message-ID: <16df1f74b07.d3ade7d625647.885482535351431524@mykernel.net>
In-Reply-To: <20191021091800.GC17810@quack2.suse.cz>
References: <20191020232326.84881-1-cgxu519@mykernel.net> <20191021091800.GC17810@quack2.suse.cz>
Subject: Re: [PATCH] ext2: adjust block num when retry allocation
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: ZohoCN Mail
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

 ---- =E5=9C=A8 =E6=98=9F=E6=9C=9F=E4=B8=80, 2019-10-21 17:18:00 Jan Kara <=
jack@suse.cz> =E6=92=B0=E5=86=99 ----
 > On Mon 21-10-19 07:23:26, Chengguang Xu wrote:
 > > Set block num to original *count in a case
 > > of retrying allocation in case num < *count
 > >=20
 > > Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
 > > ---
 > > Hi Jan,
 > >=20
 > > This patch is only compile-tested, I'm not sure if this
 > > kind of unexpected condition which causes reallocation
 > > will actually happen but baesd on the code the fix seems
 > > correct and better.
 >=20
 > Yeah, you are right that we should reset 'num' back to *count. Although =
the
 > practial effect of this is minimal - we take this code path only when th=
e
 > filesystem is corrupted. But still... Patch applied. Thanks!
=20
Thanks for your review. I found another relevant bug in ext2_try_to_allocat=
e()
today, I'll fix it up and  also plan to do some code cleanups for the alloc=
ation logic.
Do you prefer two separate patches for bugfix and cleanup or just put all i=
n a patch series?

Thanks,
Chengguang