Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1271922ybg; Wed, 23 Oct 2019 13:06:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqz9QK5H43BSFhpZw0KLQ1SYcXuD4YeDKVwGLB10uufdC99oX3otiiRmJUGbrFEMyk9f6fqk X-Received: by 2002:a17:906:1c48:: with SMTP id l8mr19186270ejg.203.1571861166255; Wed, 23 Oct 2019 13:06:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571861166; cv=none; d=google.com; s=arc-20160816; b=vJ8Oo0BkYiw1jijBevtHJmbHs6b5Uq3AT+JMkjR4hHWcB57Da3MGV/LUdhpIoAx83K E4oXJUbCQlb3ts7+/k8jKqaGGWj7n20Zywy2v4rHh15LcotTJfmEC5w4awfPMqAERXBP 1KVftiWf9rxRTYV6YgdTv2nY1BEuVI2KEgN3sp1dXq9qI42cMa+T9+Ig0KJpNYjliIAS BbfaDse/6CRwCRxG35GUb0JsQMzQzglnflGFO5Zu4SJz+hDnym3eVB+IcRB3EhxEubrB +v7wgqFqQ4IHnRfexuP3SvuGpjsidtp8GJrfqkrkwhq+wdcloW+ydXvgWZEDtI8ynIBf wbqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date; bh=Q+97zgJALDNu5nnCrNnm5GWxwIxfRQB2dXGgu6XnXhg=; b=h6DHXKmrPv6rho5nHxUL5a39PQm+Iq65idqGeYROYGgVR0GXUL5748SIGPU8swvU+r genLf1zYj7toYgn5N2IIvpgXpAGcoJFeXQZUhooZHmLqfqr5wY3Ry9d25mvLFys7Ih+b L1SO2RWOY0rpgKnbGguD/0ih/su/VB5kmSKFERQSdDBteGRoXlbZcaDYb3ic4Xc/qIu5 alhbSAhDn/VP3RyTmD/EpMwoLJ6c0bYCPYpwqp+bgpVuwpyywg/nRbLsMUw6V3EQcGf8 rh0cgSt/Ci2PJwvdqyNn14c0tbM3Xhn+WyhXbdLqTxEC8piu3PW1KDLKxFMzTofZeKwH FcxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k63si16729240edc.347.2019.10.23.13.05.41; Wed, 23 Oct 2019 13:06:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733202AbfJWNPt (ORCPT + 99 others); Wed, 23 Oct 2019 09:15:49 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:59985 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730450AbfJWNPt (ORCPT ); Wed, 23 Oct 2019 09:15:49 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-98.corp.google.com [104.133.0.98] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x9NDFkPI021775 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Oct 2019 09:15:47 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 21406420456; Wed, 23 Oct 2019 09:15:46 -0400 (EDT) Date: Wed, 23 Oct 2019 09:15:46 -0400 From: "Theodore Y. Ts'o" To: Ext4 Developers List Subject: Re: [PATCH] ext4: fix signed vs unsigned comparison in ext4_valid_extent() Message-ID: <20191023131546.GB2460@mit.edu> References: <20191023013112.18809-1-tytso@mit.edu> <20191023054447.GE361298@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023054447.GE361298@sol.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Oct 22, 2019 at 10:44:47PM -0700, Eric Biggers wrote: > > This patch can't be fixing anything because the comparison is unsigned both > before and after this patch. Thanks, you're right; I had forgotten C's signed/unsigned rules for addition. The funny thing is the original reporter of BZ #205197 reported that the problem went away he tried a similar patch. - Ted