Received-SPF: pass (google.com: best guess record for domain of linux-ext4-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chengguang Xu <cgxu519@mykernel.net>
To:     jack@suse.com
Cc:     linux-ext4@vger.kernel.org, Chengguang Xu <cgxu519@mykernel.net>
Message-ID: <20191105045100.7104-1-cgxu519@mykernel.net>
Subject: [PATCH] ext2: check err when partial != NULL
Date:   Tue,  5 Nov 2019 12:51:00 +0800
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Sender: linux-ext4-owner@vger.kernel.org
Precedence: bulk

Check err when partial =3D=3D NULL is meaningless because
partial =3D=3D NULL means getting branch successfully without
error.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 fs/ext2/inode.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index 7004ce581a32..a16c53655e77 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -701,10 +701,13 @@ static int ext2_get_blocks(struct inode *inode,
 =09=09if (!partial) {
 =09=09=09count++;
 =09=09=09mutex_unlock(&ei->truncate_mutex);
-=09=09=09if (err)
-=09=09=09=09goto cleanup;
 =09=09=09goto got_it;
 =09=09}
+
+=09=09if (err) {
+=09=09=09mutex_unlock(&ei->truncate_mutex);
+=09=09=09goto cleanup;
+=09=09}
 =09}
=20
 =09/*
--=20
2.20.1